commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 38174] - [logging][PATCH] Improvements to wrapper classes
Date Thu, 19 Jan 2006 04:38:36 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38174>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38174





------- Additional Comments From skitching@apache.org  2006-01-19 05:38 -------
As William noted, the use of String.valueOf(msg) on the input object to avoid
exceptions has significant implications. Suppose a user passes a custom
MessageRecord object as the parameter, and then has a custom Log4J Renderer
which takes this object and builds a string out of it in some clever way. By
forcing the message parameter to a string at the JCL level, that breaks the code
completely.

Boris makes the point that if someone is doing this then they really should be
using log4j directly, not JCL, because that won't work if JCL is bound to
anything other than log4j. Nevertheless, I'm inclined to avoid introding such
breakage in this release, and make a note of that point for JCL2, where we could
potentially state that all "rendering" of the message object is done by JCL for
consistency. Currently, 1.1 is very close to being backwards compatible and I
would prefer to keep it that way.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message