commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From skitch...@apache.org
Subject svn commit: r369747 - in /jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl: ./ custom/ props_disable_tccl/ props_enable_tccl/
Date Tue, 17 Jan 2006 10:40:07 GMT
Author: skitching
Date: Tue Jan 17 02:40:00 2006
New Revision: 369747

URL: http://svn.apache.org/viewcvs?rev=369747&view=rev
Log:
Tests for new feature to disable loading of LogFactory implementation via the TCCL.

Added:
    jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/
    jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/TcclDisabledTestCase.java
  (with props)
    jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/TcclEnabledTestCase.java
  (with props)
    jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/custom/
    jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/custom/MyLogFactoryImpl.java
  (with props)
    jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/props_disable_tccl/
    jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/props_disable_tccl/commons-logging.properties
    jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/props_enable_tccl/
    jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/props_enable_tccl/commons-logging.properties

Added: jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/TcclDisabledTestCase.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/TcclDisabledTestCase.java?rev=369747&view=auto
==============================================================================
--- jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/TcclDisabledTestCase.java
(added)
+++ jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/TcclDisabledTestCase.java
Tue Jan 17 02:40:00 2006
@@ -0,0 +1,144 @@
+/*
+ * Copyright 2006 The Apache Software Foundation.
+ * 
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */ 
+
+package org.apache.commons.logging.tccl;
+
+
+import java.net.URL;
+
+import junit.framework.Test;
+import junit.framework.TestCase;
+
+import org.apache.commons.logging.LogFactory;
+import org.apache.commons.logging.PathableClassLoader;
+import org.apache.commons.logging.PathableTestSuite;
+
+
+/**
+ * Verify that by default LogFactoryImpl is loaded from the tccl classloader.
+ */
+
+public class TcclDisabledTestCase extends TestCase {
+
+    // ------------------------------------------- JUnit Infrastructure Methods
+
+
+    /**
+     * Return the tests included in this test suite.
+     */
+    public static Test suite() throws Exception {
+        Class thisClass = TcclDisabledTestCase.class;
+
+        // Determine the URL to this .class file, so that we can then
+        // append the priority dirs to it. For tidiness, load this
+        // class through a dummy loader though this is not absolutely
+        // necessary...
+        PathableClassLoader dummy = new PathableClassLoader(null);
+        dummy.useSystemLoader("junit.");
+        dummy.addLogicalLib("testclasses");
+        dummy.addLogicalLib("commons-logging");
+        
+        String thisClassPath = thisClass.getName().replace('.', '/') + ".class";
+        URL baseUrl = dummy.findResource(thisClassPath);
+
+        // Now set up the desired classloader hierarchy. Everything goes into
+        // the parent classpath, but we exclude the custom LogFactoryImpl
+        // class.
+        //
+        // We then create a tccl classloader that can see the custom
+        // LogFactory class. Therefore if that class can be found, then the
+        // TCCL must have been used to load it.
+        PathableClassLoader emptyLoader = new PathableClassLoader(null);
+        
+        PathableClassLoader parentLoader = new PathableClassLoader(null);
+        parentLoader.useSystemLoader("junit.");
+        parentLoader.addLogicalLib("commons-logging");
+        parentLoader.addLogicalLib("testclasses");
+        // hack to ensure that the testcase classloader can't see
+        // the cust MyLogFactoryImpl
+        parentLoader.useExplicitLoader(
+            "org.apache.commons.logging.tccl.custom.", emptyLoader);
+        
+        URL propsEnableUrl = new URL(baseUrl, "props_disable_tccl/");
+        parentLoader.addURL(propsEnableUrl);
+
+        PathableClassLoader tcclLoader = new PathableClassLoader(parentLoader);
+        tcclLoader.addLogicalLib("testclasses");
+
+        Class testClass = parentLoader.loadClass(thisClass.getName());
+        return new PathableTestSuite(testClass, tcclLoader);
+    }
+
+    /**
+     * Set up instance variables required by this test case.
+     */
+    public void setUp() throws Exception {
+        LogFactory.releaseAll();
+    }
+
+    /**
+     * Tear down instance variables required by this test case.
+     */
+    public void tearDown() {
+        LogFactory.releaseAll();
+    }
+
+    // ----------------------------------------------------------- Test Methods
+
+    /**
+     * Verify that MyLogFactoryImpl is only loadable via the tccl.
+     */
+    public void testLoader() throws Exception {
+        
+        ClassLoader thisClassLoader = this.getClass().getClassLoader();
+        ClassLoader tcclLoader = Thread.currentThread().getContextClassLoader();
+
+        // the tccl loader should NOT be the same as the loader that loaded this test class.
+        assertNotSame("tccl not same as test classloader", thisClassLoader, tcclLoader);
+
+        // MyLogFactoryImpl should not be loadable via parent loader
+        try {
+            Class clazz = thisClassLoader.loadClass(
+                "org.apache.commons.logging.tccl.custom.MyLogFactoryImpl");
+            fail("Unexpectedly able to load MyLogFactoryImpl via test class classloader");
+        } catch(ClassNotFoundException ex) {
+            // ok, expected
+        }
+        
+        // MyLogFactoryImpl should be loadable via tccl loader
+        try {
+            Class clazz = tcclLoader.loadClass(
+                "org.apache.commons.logging.tccl.custom.MyLogFactoryImpl");
+        } catch(ClassNotFoundException ex) {
+            fail("Unexpectedly unable to load MyLogFactoryImpl via tccl classloader");
+        }
+    }
+
+    /**
+     * Verify that the custom LogFactory implementation which is only accessable
+     * via the TCCL has NOT been loaded. Because this is only accessable via the
+     * TCCL, and we've use a commons-logging.properties that disables TCCL loading,
+     * we should see the default LogFactoryImpl rather than the custom one.
+     */
+    public void testTcclLoading() throws Exception {
+        LogFactory instance = LogFactory.getFactory();
+        
+        assertEquals(
+            "Correct LogFactory loaded", 
+            "org.apache.commons.logging.impl.LogFactoryImpl",
+            instance.getClass().getName());
+    }
+}

Propchange: jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/TcclDisabledTestCase.java
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/TcclDisabledTestCase.java
------------------------------------------------------------------------------
    svn:keywords = Author Date Id Revision

Added: jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/TcclEnabledTestCase.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/TcclEnabledTestCase.java?rev=369747&view=auto
==============================================================================
--- jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/TcclEnabledTestCase.java
(added)
+++ jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/TcclEnabledTestCase.java
Tue Jan 17 02:40:00 2006
@@ -0,0 +1,144 @@
+/*
+ * Copyright 2006 The Apache Software Foundation.
+ * 
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */ 
+
+package org.apache.commons.logging.tccl;
+
+
+import java.net.URL;
+
+import junit.framework.Test;
+import junit.framework.TestCase;
+
+import org.apache.commons.logging.LogFactory;
+import org.apache.commons.logging.PathableClassLoader;
+import org.apache.commons.logging.PathableTestSuite;
+import org.apache.commons.logging.config.PriorityConfigTestCase;
+
+
+/**
+ * Verify that by default LogFactoryImpl is loaded from the tccl classloader.
+ */
+
+public class TcclEnabledTestCase extends TestCase {
+
+    // ------------------------------------------- JUnit Infrastructure Methods
+
+
+    /**
+     * Return the tests included in this test suite.
+     */
+    public static Test suite() throws Exception {
+        Class thisClass = TcclEnabledTestCase.class;
+
+        // Determine the URL to this .class file, so that we can then
+        // append the priority dirs to it. For tidiness, load this
+        // class through a dummy loader though this is not absolutely
+        // necessary...
+        PathableClassLoader dummy = new PathableClassLoader(null);
+        dummy.useSystemLoader("junit.");
+        dummy.addLogicalLib("testclasses");
+        dummy.addLogicalLib("commons-logging");
+        
+        String thisClassPath = thisClass.getName().replace('.', '/') + ".class";
+        URL baseUrl = dummy.findResource(thisClassPath);
+
+        // Now set up the desired classloader hierarchy. Everything goes into
+        // the parent classpath, but we exclude the custom LogFactoryImpl
+        // class.
+        //
+        // We then create a tccl classloader that can see the custom
+        // LogFactory class. Therefore if that class can be found, then the
+        // TCCL must have been used to load it.
+        PathableClassLoader emptyLoader = new PathableClassLoader(null);
+        
+        PathableClassLoader parentLoader = new PathableClassLoader(null);
+        parentLoader.useSystemLoader("junit.");
+        parentLoader.addLogicalLib("commons-logging");
+        parentLoader.addLogicalLib("testclasses");
+        // hack to ensure that the testcase classloader can't see
+        // the cust MyLogFactoryImpl
+        parentLoader.useExplicitLoader(
+            "org.apache.commons.logging.tccl.custom.", emptyLoader);
+        
+        URL propsEnableUrl = new URL(baseUrl, "props_enable_tccl/");
+        parentLoader.addURL(propsEnableUrl);
+
+        PathableClassLoader tcclLoader = new PathableClassLoader(parentLoader);
+        tcclLoader.addLogicalLib("testclasses");
+
+        Class testClass = parentLoader.loadClass(thisClass.getName());
+        return new PathableTestSuite(testClass, tcclLoader);
+    }
+
+    /**
+     * Set up instance variables required by this test case.
+     */
+    public void setUp() throws Exception {
+        LogFactory.releaseAll();
+    }
+
+    /**
+     * Tear down instance variables required by this test case.
+     */
+    public void tearDown() {
+        LogFactory.releaseAll();
+    }
+
+    // ----------------------------------------------------------- Test Methods
+
+    /**
+     * Verify that MyLogFactoryImpl is only loadable via the tccl.
+     */
+    public void testLoader() throws Exception {
+        
+        ClassLoader thisClassLoader = this.getClass().getClassLoader();
+        ClassLoader tcclLoader = Thread.currentThread().getContextClassLoader();
+
+        // the tccl loader should NOT be the same as the loader that loaded this test class.
+        assertNotSame("tccl not same as test classloader", thisClassLoader, tcclLoader);
+
+        // MyLogFactoryImpl should not be loadable via parent loader
+        try {
+            Class clazz = thisClassLoader.loadClass(
+                "org.apache.commons.logging.tccl.custom.MyLogFactoryImpl");
+            fail("Unexpectedly able to load MyLogFactoryImpl via test class classloader");
+        } catch(ClassNotFoundException ex) {
+            // ok, expected
+        }
+        
+        // MyLogFactoryImpl should be loadable via tccl loader
+        try {
+            Class clazz = tcclLoader.loadClass(
+                "org.apache.commons.logging.tccl.custom.MyLogFactoryImpl");
+        } catch(ClassNotFoundException ex) {
+            fail("Unexpectedly unable to load MyLogFactoryImpl via tccl classloader");
+        }
+    }
+
+    /**
+     * Verify that the custom LogFactory implementation which is only accessable
+     * via the TCCL has successfully been loaded as specified in the config file.
+     * This proves that the TCCL was used to load that class.
+     */
+    public void testTcclLoading() throws Exception {
+        LogFactory instance = LogFactory.getFactory();
+        
+        assertEquals(
+            "Correct LogFactory loaded", 
+            "org.apache.commons.logging.tccl.custom.MyLogFactoryImpl",
+            instance.getClass().getName());
+    }
+}

Propchange: jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/TcclEnabledTestCase.java
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/TcclEnabledTestCase.java
------------------------------------------------------------------------------
    svn:keywords = Author Date Id Revision

Added: jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/custom/MyLogFactoryImpl.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/custom/MyLogFactoryImpl.java?rev=369747&view=auto
==============================================================================
--- jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/custom/MyLogFactoryImpl.java
(added)
+++ jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/custom/MyLogFactoryImpl.java
Tue Jan 17 02:40:00 2006
@@ -0,0 +1,31 @@
+/*
+ * Copyright 2006 The Apache Software Foundation.
+ * 
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */ 
+
+package org.apache.commons.logging.tccl.custom;
+
+
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+
+public class MyLogFactoryImpl extends LogFactory {
+    public Object getAttribute(String name) { return null; }
+    public String[] getAttributeNames() { return null; }
+    public Log getInstance(Class clazz) { return null; }
+    public Log getInstance(String name) { return null; }
+    public void release() {}
+    public void removeAttribute(String name) {}
+    public void setAttribute(String name, Object value) {}
+}

Propchange: jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/custom/MyLogFactoryImpl.java
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/custom/MyLogFactoryImpl.java
------------------------------------------------------------------------------
    svn:keywords = Author Date Id Revision

Added: jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/props_disable_tccl/commons-logging.properties
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/props_disable_tccl/commons-logging.properties?rev=369747&view=auto
==============================================================================
--- jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/props_disable_tccl/commons-logging.properties
(added)
+++ jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/props_disable_tccl/commons-logging.properties
Tue Jan 17 02:40:00 2006
@@ -0,0 +1 @@
+use_tccl=false

Added: jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/props_enable_tccl/commons-logging.properties
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/props_enable_tccl/commons-logging.properties?rev=369747&view=auto
==============================================================================
--- jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/props_enable_tccl/commons-logging.properties
(added)
+++ jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/props_enable_tccl/commons-logging.properties
Tue Jan 17 02:40:00 2006
@@ -0,0 +1 @@
+org.apache.commons.logging.LogFactory=org.apache.commons.logging.tccl.custom.MyLogFactoryImpl



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message