commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 30941] - [beanutils] Default converter for LocaleConvertUtilsBean
Date Sun, 08 Jan 2006 06:58:29 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=30941>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30941





------- Additional Comments From weigao@hotmail.com  2006-01-08 07:58 -------
I don't quite understand why LocaleConvertUtilBean is not extends from
ConvertUtilBean. And why LocaleBeanUtilsBean has two convert util beans, one is
ConvertUtilBean, and another one is LocaleConvertUtilBean.

I understand that not all converter need L10N, for example: BooleanConverter, so
we don't need to register them into LocaleConvertUtilsBean. But this really
confuse the user, when to use LocaleConvertUtilsBean, and when to use
ConvertUtilsBean? Also, BeanUtils.copyProperties will always use
ConvertUtilsBean to do the convertion job, this occurred another bug (16038).

I'm thinking to make the following modification to fix it by:

1. Make LocaleConvertUtilsBean extends from ConvertUtilsBean.
2. Make property "convertUtilsBean" in BeanUtilsBean protected, so it can been
accessed by LocaleBeanUtilsBean.
3. Remove localeConvertUtilsBean from LocaleBeanUtilsBean.
4. lookup in LocaleBeanUtilsBean will return converter for Locale, or converter
from ConvertUtilsBean directly if no converter found for that Locale.

I will attach my modification made base on release 1.7.0

Unforturnately, I haven't did any test except original unit test cases yet.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message