commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 38083] - [io][PATCH] Iterate over the lines in a file and the files in a directory
Date Thu, 05 Jan 2006 22:07:51 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38083>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38083





------- Additional Comments From sjr@jdns.org  2006-01-05 23:07 -------
Hi there,

(In reply to comment #5)
> Created an attachment (id=17340)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=17340&action=view) [edit]
> Patch FileUtils and IOUtils to provide static methods for LineIterator
> 

+    public static Iterator lineIterator(InputStream input, String encoding) 
+                     throws UnsupportedEncodingException {

I think it's better if you declare a return type of LineIterator. This way, no
casts are necessary. People who don't care about the fact that it's a
LineReader will just say

Iterator i = FileUtils.lineIterator( blah );

Those who do will say

LineIterator i = FileUtils.lineIterator( blah );

Regards,
James

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message