commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robert burrell donkin <robertburrelldon...@blueyonder.co.uk>
Subject Re: [logging] Bug 38174 and JCL 1.1
Date Thu, 19 Jan 2006 22:53:25 GMT
On Thu, 2006-01-19 at 20:23 +0000, robert burrell donkin wrote:
> On Thu, 2006-01-19 at 19:17 +0100, Boris Unckel wrote:
> > Hello,
> > 
> > Simon Kitching wrote:
> > >>> NB: I'm hoping to knock JCL1.1 into releasable state over the coming
> > >>> weekend and hold a vote on creating the first RC.
> > >> Please check to put the patch in bug 38174 into RC. Even if you decide
> > >> against the logic in the new "doLog" methods, it would be nice to have

> > >> the other cleanup (javadoc, same null behaviour for all classes).
> > >
> > > Please check my comments on that bugzilla entry.
> > >
> > 
> > I have read your comments and opinions in the bugzilla entry[1].
> > As I do not want to put so much time in a more or less boring task
> > (improving the JavaDoc and care for doLog single method logic is a lot of
> > copy and correct paste) I have removed anything of the exception behaviour.
> > I have also removed the String.valueOf when the underlying logger accepts
> > objects as message.
> > 
> > Every file has single patch. With accident cause I did an format after
> > removing the exception handling - sorry for that, it will cause more diff
> > than is really different.
> > 
> > Please consider again to put this into release.
> 
> i'm going through the patches (by hand) now. 

i've applied the javadoc changes. i may review the other bits later (if
time allows) but that's about it for me for tonight. i'm unlikely to be
online tomorrow. i plan to try to write some documentation on saturday. 

- robert


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message