Return-Path: 
 <commons-dev-return-81234-apmail-jakarta-commons-dev-archive=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org
Received: (qmail 5915 invoked from network); 6 Dec 2005 06:05:15 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 6 Dec 2005 06:05:15 -0000
Received: (qmail 61603 invoked by uid 500); 6 Dec 2005 06:05:01 -0000
Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org
Received: (qmail 61467 invoked by uid 500); 6 Dec 2005 06:05:00 -0000
Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:commons-dev-unsubscribe@jakarta.apache.org>
List-Help: <mailto:commons-dev-help@jakarta.apache.org>
List-Post: <mailto:commons-dev@jakarta.apache.org>
List-Id: "Jakarta Commons Developers List" <commons-dev.jakarta.apache.org>
Reply-To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Delivered-To: mailing list commons-dev@jakarta.apache.org
Received: (qmail 61393 invoked by uid 500); 6 Dec 2005 06:05:00 -0000
Received: (qmail 61382 invoked by uid 99); 6 Dec 2005 06:05:00 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Dec 2005 22:05:00 -0800
X-ASF-Spam-Status: No, hits=-9.4 required=10.0
	tests=ALL_TRUSTED,NO_REAL_NAME
X-Spam-Check-By: apache.org
Received: from [209.237.227.194] (HELO minotaur.apache.org) (209.237.227.194)
    by apache.org (qpsmtpd/0.29) with SMTP; Mon, 05 Dec 2005 22:04:59 -0800
Received: (qmail 5691 invoked by uid 65534); 6 Dec 2005 06:04:39 -0000
Message-ID: <20051206060439.5688.qmail@minotaur.apache.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r354328 - in /jakarta/commons/proper/fileupload/trunk:
 fileupload_basic.xml fileupload_checks.xml project.properties
Date: Tue, 06 Dec 2005 06:04:38 -0000
To: commons-cvs@jakarta.apache.org
From: martinc@apache.org
X-Mailer: svnmailer-1.0.5
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

Author: martinc
Date: Mon Dec  5 22:04:33 2005
New Revision: 354328

URL: http://svn.apache.org/viewcvs?rev=354328&view=rev
Log:
* Target JRE 1.3 VMs.
* Tweak Checkstyle rules to be more stringent.
* Add custom PMD rule configuration.

Added:
    jakarta/commons/proper/fileupload/trunk/fileupload_basic.xml   (with props)
Modified:
    jakarta/commons/proper/fileupload/trunk/fileupload_checks.xml
    jakarta/commons/proper/fileupload/trunk/project.properties

Added: jakarta/commons/proper/fileupload/trunk/fileupload_basic.xml
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/fileupload/trunk/fileupload_basic.xml?rev=354328&view=auto
==============================================================================
--- jakarta/commons/proper/fileupload/trunk/fileupload_basic.xml (added)
+++ jakarta/commons/proper/fileupload/trunk/fileupload_basic.xml Mon Dec  5 22:04:33 2005
@@ -0,0 +1,9 @@
+<?xml version="1.0"?>
+
+<ruleset name="FileUpload Basic Rules">
+  <description>PMD Basic Ruleset minus the EmptyCatchBlock rule.</description>
+
+  <rule ref="rulesets/basic.xml">
+    <exclude name="EmptyCatchBlock"/>
+  </rule>
+</ruleset>

Propchange: jakarta/commons/proper/fileupload/trunk/fileupload_basic.xml
------------------------------------------------------------------------------
    svn:keywords = Date Author Id Revision HeadURL

Modified: jakarta/commons/proper/fileupload/trunk/fileupload_checks.xml
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/fileupload/trunk/fileupload_checks.xml?rev=354328&r1=354327&r2=354328&view=diff
==============================================================================
--- jakarta/commons/proper/fileupload/trunk/fileupload_checks.xml (original)
+++ jakarta/commons/proper/fileupload/trunk/fileupload_checks.xml Mon Dec  5 22:04:33 2005
@@ -138,7 +138,11 @@
         <!-- Checks for Size Violations.                    -->
         <!-- See http://checkstyle.sf.net/config_sizes.html -->
         <module name="FileLength"/>
-        <module name="LineLength"/>
+        <!-- Begin Custom for FileUpload -->
+        <module name="LineLength">
+          <property name="ignorePattern" value="^ \* @version .*$"/>
+        </module>
+        <!-- End Custom for FileUpload -->
         <module name="MethodLength"/>
         <module name="ParameterNumber"/>
 
@@ -165,7 +169,11 @@
         <!-- Checks for blocks. You know, those {}'s         -->
         <!-- See http://checkstyle.sf.net/config_blocks.html -->
         <module name="AvoidNestedBlocks"/>
-        <!-- Disabled for FileUpload: module name="EmptyBlock"/ -->
+        <!-- Begin Custom for FileUpload -->
+        <module name="EmptyBlock">
+          <property name="option" value="text"/>
+        </module>
+        <!-- End Custom for FileUpload -->
         <module name="LeftCurly"/>
         <module name="NeedBraces"/>
         <module name="RightCurly"/>

Modified: jakarta/commons/proper/fileupload/trunk/project.properties
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/fileupload/trunk/project.properties?rev=354328&r1=354327&r2=354328&view=diff
==============================================================================
--- jakarta/commons/proper/fileupload/trunk/project.properties (original)
+++ jakarta/commons/proper/fileupload/trunk/project.properties Mon Dec  5 22:04:33 2005
@@ -22,14 +22,23 @@
 compile.optimize = off
 compile.deprecation = off
 
-maven.compile.source=1.4
-maven.compile.target=1.4
+maven.compile.source=1.3
+maven.compile.target=1.3
 
 maven.checkstyle.properties = ${basedir}/fileupload_checks.xml
 checkstyle.regexp.header=${basedir}/license-header.txt
 
+maven.pmd.rulesetfiles=fileupload_basic.xml,rulesets/unusedcode.xml,rulesets/imports.xml
+
 maven.javadoc.additionalparam=-tag todo:a:"To Do:"
-maven.linkcheck.enable=true 
+maven.linkcheck.enable=true
+
+# Ostensibly, changes since the FileUpload 1.0 release at SVN revision 133359.
+# Unfortunately, it doesn't work, which is why it's commented out.
+# I guess I'll have to compile the release notes without Maven's help.
+# (The plugin needs to support SVN revision numbers, which it doesn't today.)
+#maven.changelog.type = date
+#maven.changelog.date = 2003-06-24
 
 # documentation properties
 maven.xdoc.jsl=../commons-build/commons-site.jsl



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org