commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Bourg <>
Subject Re: [configuration] New tree package
Date Wed, 28 Dec 2005 23:02:27 GMT
Oliver Heger wrote:

> As I have promised, I plan to add support for XPATH queries to
> (hierarchical) configurations. In a first step I did some polishing of
> the Node class used internally by HierarchicalConfiguration; the current
> way of storing child nodes and attributes made it very difficult to
> efficiently select nodes based on queries. For this purpose I added a
> new tree package, which ATM is somewhat experimental.

Great! I looked quickly at the patch, some thoughts:

- ConfigurationNode, a shorter name would be better, but I don't have a 
good alternative. We can't reuse "Node" since it's the name of the inner 
class in HierarchicalConfiguration. Maybe the refactoring could be 
pushed further by extracting HierarchicalConfiguration.Node and merging 
it into the top level default Node implementation. This will break the 
compatibility, but on the other hand the methods dealing with the nodes 
are not frequently used by the final users.

- Attributes: XMLConfiguration is the only hierarchical configuration to 
expose attributes. What about moving the methods of ConfigurationNode 
dealing with the attributes in the XMLNode implementation ? Unless an 
attribute is defined as a child node with a value and no children ?

> Next thing I am going to do is extracting code that interprets property
> keys from HierarchicalConfiguration.

Do you plan to depend on an external library like jxpath ? If we could 
keep it optional that would be nice.

Emmanuel Bourg

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message