commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ebo...@apache.org
Subject svn commit: r354017 - in /jakarta/commons/proper/configuration/trunk/conf: checkstyle-suppressions.xml checkstyle.xml
Date Mon, 05 Dec 2005 08:22:05 GMT
Author: ebourg
Date: Mon Dec  5 00:21:58 2005
New Revision: 354017

URL: http://svn.apache.org/viewcvs?rev=354017&view=rev
Log:
The classes generated by JavaCC are no longer checked by CheckStyke
Removed the FileLength check, it should not take the javadoc into consideration
Allowed the declaration of unchecked exceptions
Added '3' as a magic number
Javadoc is now mandatory for public methods only

Added:
    jakarta/commons/proper/configuration/trunk/conf/checkstyle-suppressions.xml
Modified:
    jakarta/commons/proper/configuration/trunk/conf/checkstyle.xml

Added: jakarta/commons/proper/configuration/trunk/conf/checkstyle-suppressions.xml
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/configuration/trunk/conf/checkstyle-suppressions.xml?rev=354017&view=auto
==============================================================================
--- jakarta/commons/proper/configuration/trunk/conf/checkstyle-suppressions.xml (added)
+++ jakarta/commons/proper/configuration/trunk/conf/checkstyle-suppressions.xml Mon Dec  5
00:21:58 2005
@@ -0,0 +1,20 @@
+<?xml version="1.0"?>
+
+<!DOCTYPE suppressions PUBLIC
+    "-//Puppy Crawl//DTD Suppressions 1.0//EN"
+    "http://www.puppycrawl.com/dtds/suppressions_1_0.dtd">
+
+<!-- Exceptions for Checkstyle -->
+
+<suppressions>
+
+    <!-- Disable the warnings for the generated classes -->
+    <suppress checks=".*" files="ParseException.java"/>
+    <suppress checks=".*" files="PropertyListParser.java"/>
+    <suppress checks=".*" files="PropertyListParserConstants.java"/>
+    <suppress checks=".*" files="PropertyListParserTokenManager.java"/>
+    <suppress checks=".*" files="SimpleCharStream.java"/>
+    <suppress checks=".*" files="Token.java"/>
+    <suppress checks=".*" files="TokenMgrError.java"/>
+
+</suppressions>

Modified: jakarta/commons/proper/configuration/trunk/conf/checkstyle.xml
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/configuration/trunk/conf/checkstyle.xml?rev=354017&r1=354016&r2=354017&view=diff
==============================================================================
--- jakarta/commons/proper/configuration/trunk/conf/checkstyle.xml (original)
+++ jakarta/commons/proper/configuration/trunk/conf/checkstyle.xml Mon Dec  5 00:21:58 2005
@@ -20,6 +20,10 @@
     <!-- See http://checkstyle.sf.net/config_misc.html#Translation -->
     <module name="Translation"/>
 
+    <!-- Exceptions -->
+    <module name="SuppressionFilter">
+        <property name="file" value="conf/checkstyle-suppressions.xml"/>
+    </module>
 
     <module name="TreeWalker">
 
@@ -28,6 +32,7 @@
         <!-- Checks for Javadoc comments.                     -->
         <!-- See http://checkstyle.sf.net/config_javadoc.html -->
         <module name="JavadocMethod">
+            <property name="scope" value="public"/>
             <property name="allowUndeclaredRTE" value="true"/>
         </module>
         <module name="JavadocType">
@@ -70,7 +75,7 @@
 
         <!-- Checks for Size Violations.                    -->
         <!-- See http://checkstyle.sf.net/config_sizes.html -->
-        <module name="FileLength"/>
+        <!--<module name="FileLength"/>-->
         <module name="LineLength">
             <property name="max" value="120"/>
         </module>
@@ -117,9 +122,13 @@
         <module name="EqualsHashCode"/>
         <module name="IllegalInstantiation"/>
         <module name="InnerAssignment"/>
-        <module name="MagicNumber"/>
+        <module name="MagicNumber">
+            <property name="ignoreNumbers" value="-1,0,1,2,3"/>
+        </module>
         <module name="MissingSwitchDefault"/>
-        <module name="RedundantThrows"/>
+        <module name="RedundantThrows">
+            <property name="allowUnchecked" value="true"/>
+        </module>
         <module name="SimplifyBooleanExpression"/>
         <module name="SimplifyBooleanReturn"/>
         <module name="StringLiteralEquality"/>



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message