Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
From: bugzilla@apache.org
To: commons-dev@jakarta.apache.org
Subject: DO NOT REPLY [Bug 37379]  -
    [transaction] FileResourceManager fails on Xids because of toString()
 usage for directory names
Message-Id: <20051111222355.CD57D21F@ajax.apache.org>
Date: Fri, 11 Nov 2005 23:23:55 +0100 (CET)

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=37379>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37379


------- Additional Comments From ozeigermann@apache.org  2005-11-11 23:23 -------
(In reply to comment #8)
> (In reply to comment #7)
> > Additionally, your standard implementation for
> > 
> > getTransactionBaseDir
> > 
> > is not acceptable as a described before. This should either be configurable or
> > have a more reasonable implementation as also described before.
> 
> Another possibility would be to use generatedUniqueTxId() as base for the
> directory name and to store the mapping of transaction IDs to directory names in
> a map. For transaction Ids already generated with the above method the key would
> be the same as the value, for external IDs like my Xids this would map the Xid
> to the directory name. As the generatedUniqueTxId() is assumed to work at the
> moment, this should work too. WDYT?


Sounds like a reasonable approach. However, for the default implementation I
would like to stick to the schema that is used now. When you make
getTransactionBaseDir overridable you can easily implement whatever mapping you
like. 

This means, taks over your idea minus the implementation in
getTransactionBaseDir which will continue to return the direct string.

Agreed?

Oliver

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org