commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pste...@apache.org
Subject svn commit: r348896 - /jakarta/commons/proper/math/branches/MATH_1_1/checkstyle.xml
Date Fri, 25 Nov 2005 06:47:58 GMT
Author: psteitz
Date: Thu Nov 24 22:47:55 2005
New Revision: 348896

URL: http://svn.apache.org/viewcvs?rev=348896&view=rev
Log:
Added some checks.

Modified:
    jakarta/commons/proper/math/branches/MATH_1_1/checkstyle.xml

Modified: jakarta/commons/proper/math/branches/MATH_1_1/checkstyle.xml
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/math/branches/MATH_1_1/checkstyle.xml?rev=348896&r1=348895&r2=348896&view=diff
==============================================================================
--- jakarta/commons/proper/math/branches/MATH_1_1/checkstyle.xml (original)
+++ jakarta/commons/proper/math/branches/MATH_1_1/checkstyle.xml Thu Nov 24 22:47:55 2005
@@ -23,25 +23,52 @@
   <property name="localeLanguage" value="en"/>
 
   <module name="TreeWalker">
+   
     <!-- Verify that EVERY source file has the appropriate license -->
     <module name="Header">
       <property name="headerFile" value="license-header.txt"/>
       <property name="ignoreLines" value="2"/>
     </module>
 
+    <!-- Operator must be at end of wrapped line -->
     <module name="OperatorWrap">
       <property name="option" value="eol"/>
     </module>
+    
+    <!-- Interfaces must be types (not just constants) -->
+    <module name="InterfaceIsType"/>
 
-		<module name="JavadocType">
-  		<property name="versionFormat" value="\$Revision.*\$ \$Date.*\$"/>
-		</module>
+    <!-- Must have class / interface header comments including scm version -->
+	<module name="JavadocType">
+  	  <property name="versionFormat" value="\$Revision.*\$ \$Date.*\$"/>
+	</module>
 		
-		<module name="JavadocMethod">
-			<property name="allowUndeclaredRTE" value="true"/>
-		</module>
+     <!-- Require method javadocs, allow undeclared RTE -->
+	<module name="JavadocMethod">
+	  <property name="allowUndeclaredRTE" value="true"/>
+	</module>
 		
-		<module name="JavadocVariable"/>
+    <!-- Require field javadoc -->
+	<module name="JavadocVariable"/>
+		
+    <!-- No tabs allowed! -->
+	<module name="TabCharacter"/>
+	
+	<!-- No public fields -->
+	<module name="VisibilityModifier">
+       <property name="protectedAllowed" value="true"/>
+    </module>
+	
+	<!-- Require hash code override when equals is -->
+	<module name="EqualsHashCode"/>
+	
+	<!-- Disallow unecessary instantiantion of Boolean, String -->
+	<module name="IllegalInstantiation">
+      <property name="classes" value="java.lang.Boolean, java.lang.String"/>
+    </module>
   </module>
+  
+  <!-- Require package javadoc -->
+  <module name="PackageHtml"/>
 </module>
 



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message