Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 27247 invoked from network); 14 Oct 2005 11:40:30 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 14 Oct 2005 11:40:30 -0000 Received: (qmail 9211 invoked by uid 500); 14 Oct 2005 11:39:13 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 8482 invoked by uid 500); 14 Oct 2005 11:39:08 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 6643 invoked by uid 99); 14 Oct 2005 11:38:52 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Oct 2005 04:38:52 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [69.17.117.24] (HELO mail22.sea5.speakeasy.net) (69.17.117.24) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Oct 2005 04:37:47 -0700 Received: (qmail 7170 invoked from network); 14 Oct 2005 11:37:24 -0000 Received: from dsl254-067-087.nyc1.dsl.speakeasy.net (HELO [192.168.254.100]) (elharo@[216.254.67.87]) (envelope-sender ) by mail22.sea5.speakeasy.net (qmail-ldap-1.03) with AES256-SHA encrypted SMTP for ; 14 Oct 2005 11:37:23 -0000 Message-ID: <434F9872.8060801@metalab.unc.edu> Date: Fri, 14 Oct 2005 07:37:22 -0400 From: Elliotte Harold User-Agent: Thunderbird 1.4 (Macintosh/20050908) MIME-Version: 1.0 To: commons-dev@jakarta.apache.org Subject: Unnecessary casts in Commons-Math Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N I loaded Commons-Math into Eclipse, which promptly complained about numerous unnecessary casts. For example, this cast to double in LaguerreSolver.solve: Complex N = new Complex((double)n, 0.0); Complex N1 = new Complex((double)(n-1), 0.0); If I submitted a patch to remove these unnecessary casts, would it be likely to be accepted or rejected? Personally I find extra code like this to be very ugly, but I know some programmers and projects like these casts. If the commons-math policy is to use these, I'll set my Eclipse project preferences to ignore this. If not I can patch it. What do people prefer? -- Elliotte Rusty Harold elharo@metalab.unc.edu XML in a Nutshell 3rd Edition Just Published! http://www.cafeconleche.org/books/xian3/ http://www.amazon.com/exec/obidos/ISBN=0596007647/cafeaulaitA/ref=nosim --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org