commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 37034] - Loading of resources causes webapp to fail redeploy under Tomcat 5.5.x
Date Wed, 12 Oct 2005 07:22:29 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=37034>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37034





------- Additional Comments From skitching@apache.org  2005-10-12 09:22 -------
Thanks very much for your patch, Rich.

I've got no objection to this change in principle. Clearly the correct place to
fix it *is* in the JDK's implementation of InputSource, but this wouldn't be the
first workaround for a JDK bug in Digester.

There is a potential issue with the provided patch, which is that the
InputSource is created with no knowledge of the systemId (just a Stream) which
means that relative paths within the resource won't work any longer. I think
that can be fixed by just doing:

  InputSource is = new InputSource(urlConnection.getInputStream());
  is.setSystemId(entityURL);
  return is;

And there should also be a comment in the code explaining why this simple task
is being implemented in this odd manner. 

I don't have much time to analyse this patch properly just at the moment; I'll
try to do so at the weekend if someone else doesn't commit this before then.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message