commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robert burrell donkin <robertburrelldon...@blueyonder.co.uk>
Subject Re: [logging] getChildLogger Patch submitted to bugzilla issue #36062
Date Sun, 09 Oct 2005 15:44:04 GMT
On Sat, 2005-10-01 at 02:07 +0200, Joerg Hohwiller wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi there,
> 
> it all works and all tests passed.
> I submitted the full patch at
> http://issues.apache.org/bugzilla/show_bug.cgi?id=36062
> 
> Discussion is most welcome.

1 IMHO Logger is used far too often already. i'd prefer another name. i
don't think that IoCLog is not commonly used so that's a possibility.
not sure whether that'd be a good or bad name. Log2 is used often used
in this circumstance. LogPlus is unique and novel. 

opinions? 
 
2 for me, the documentation for this would be critical. i'd like to have
a firm commitment for good documentation to be produce to go with this
patch.

3 should probably go through the old bugzilla reports and see whether
there are any other bits and pieces which are missing from Log and
should be added to log2.

4 not happy about upgrading the log4j dependency at the same time.

5 should use a string buffer in getChildLoggerName.

6 bit unsure about fitting a superclass (AbstractLogger) just to provide
a utility method. sometimes this can prove harmful in the long run since
it may limit inheritance options for the future. can't think of any
reason why this would apply in this case right now, though.

opinions?

- robert


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message