Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 60383 invoked from network); 20 Sep 2005 06:07:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 20 Sep 2005 06:07:53 -0000 Received: (qmail 14947 invoked by uid 500); 20 Sep 2005 06:07:45 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 14833 invoked by uid 500); 20 Sep 2005 06:07:45 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 14798 invoked by uid 99); 20 Sep 2005 06:07:45 -0000 X-ASF-Spam-Status: No, hits=0.2 required=10.0 tests=NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [192.87.106.226] (HELO ajax.apache.org) (192.87.106.226) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Sep 2005 23:07:43 -0700 Received: by ajax.apache.org (Postfix, from userid 99) id 1DFAF125; Tue, 20 Sep 2005 08:07:11 +0200 (CEST) From: bugzilla@apache.org To: commons-dev@jakarta.apache.org Subject: DO NOT REPLY [Bug 36719] - Most ObjectPool.borrowObject() implementations do not call validateObject() X-Bugzilla-Reason: AssignedTo Message-Id: <20050920060711.1DFAF125@ajax.apache.org> Date: Tue, 20 Sep 2005 08:07:11 +0200 (CEST) X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG� RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND� INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36719 ------- Additional Comments From Sandy@McArthur.org 2005-09-20 08:07 ------- Created an attachment (id=16453) --> (http://issues.apache.org/bugzilla/attachment.cgi?id=16453&action=view) borrowObject() fixes and unit tests With this patch TestStackObjectPool.testBorrowReturnWithSometimesInvalidObjects() fails. I think this test is broken or at least it shouldn't have the assertEquals(3,pool.getNumIdle()); at the end. Best case this test was intended to check for unexpected exceptions and the assertEquals isn't needed or worst case the test incorrectly asserts that broken behavior is valid. Please let me know if I misunderstood it's intent. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org