Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Received-SPF: pass (asf.osuosl.org: domain of
 robertburrelldonkin@blueyonder.co.uk designates 195.188.213.5 as permitted
 sender)
Subject: Re: [Digester] - object-param-rule strange attribute
From: robert burrell donkin <robertburrelldonkin@blueyonder.co.uk>
To: Jakarta Commons Developers List <commons-dev@jakarta.apache.org>
In-Reply-To: <1125123946.3823.9.camel@localhost.localdomain>
References: <20050826155249.0asu0xajxcogsckk@imp4.free.fr>
	 <1125123946.3823.9.camel@localhost.localdomain>
Content-Type: text/plain; charset=ISO-8859-1
Date: Thu, 01 Sep 2005 22:23:32 +0100
Message-Id: <1125609812.5041.78.camel@knossos.elmet>
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

On Sat, 2005-08-27 at 18:25 +1200, Simon Kitching wrote:
> On Fri, 2005-08-26 at 15:52 +0200, S=E9bastien wrote:
> > Hi,
> > I looked at the DTD of digester-rules and I found something strange. It=
 defines
> > an attribute named param for the tag object-param-rule. This attribute =
is
> > marked as REQUIRED but is never used in the factory... What is its purp=
ose (I
> > guess none but why is it there then ?)
>=20
> Good question. I don't know either. The code was committed by Robert
> Donkin in October 2003, with comment
>    Added support for ObjectParamRule to xmlrules.=20
>    Patch contributed by Anton Maslovsky.
>=20
> As far as I can see, the param element doesn't have any purpose.
>=20
> The ObjectParamRule doesn't really make sense when using xmlrules
> anyway; it's a way of passing an arbitrary java object to the target
> method which is very useful when using the API.
>=20
> In its current form, it looks to me like:
> * "type" must specify a java class name.
> * if value is not specified, then a default instance of that
>   type is passed, else convertutils is used to convert the
>   value string into the specified type.
>=20
> As you say, attribute "param" isn't used anywhere. I don't believe that
> digester's xmlrules module validates the xmlrules file against the dtd
> anyway, so it can safely be left out. There are a couple of unit tests
> for the object-param-rule tag, and neither of them define attribute
> "param".
>=20
> Perhaps you could create a bugzilla entry for this??

no need: this is definitely a bug in DTD. i've committed the removal of
that element.

- robert


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org