commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 36773] - [digester] [PATCH] NodeCreateRule does not correctly handle namespaced attributes
Date Thu, 29 Sep 2005 18:51:22 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=36773>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36773





------- Additional Comments From rdonkin@apache.org  2005-09-29 20:51 -------
Hi Kurt

Please understand's not quite as simple as that.

1. Digester is used extensively where loosy binding is perfectly accceptable. 
2. Digester is old and flexible enough to have to worry about maintaining
compatibility with parsers which are not namespace aware.

However, in this case I've taken a look at the DOM specification and believe
that the passage of code in question is just buggy. DOM expects the qualified
(and not the local) name. I suspect that this is so that it can extract the
prefix for it's own uses. My reading of the API implies that the Element parses
the qualified name to extract the local name itself. Therefore, applying this
patch should not change the existing behaviour and so will do no harm.

Probably worth creating a unit test for the case where there is no namespace,
though. 

Opinions?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message