commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 36773] - [digester] [PATCH] NodeCreateRule does not correctly handle namespaced attributes
Date Sun, 25 Sep 2005 04:01:02 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=36773>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36773





------- Additional Comments From skitching@apache.org  2005-09-25 06:01 -------
Looks correct to me. 

The only potential issue is that this will change the existing behaviour of
digester. Formerly, calling getName on the attribute would return the localname
part. After this fix it would return the qualified name, which is correct. But
this *could* break existing applications.

Does anyone think this breakage is a significant problem? If so, we could add
some kind of flag on the Digester class to select the old (wrong) or new (right)
behaviour, at least for a release or two, eg:
  Digester.setRetainAttributePrefixes(boolean)
which would default to false (the old behaviour). I personally think this would
be wise; digester usage is fairly widely spread so incompatible changes can
cause significant grief.

Regards,

Simon

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message