commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pste...@apache.org
Subject svn commit: r280049 - in /jakarta/commons/proper/math/branches/MATH_1_1/src: java/org/apache/commons/math/analysis/BisectionSolver.java test/org/apache/commons/math/complex/ComplexTest.java
Date Sat, 10 Sep 2005 23:37:43 GMT
Author: psteitz
Date: Sat Sep 10 16:37:39 2005
New Revision: 280049

URL: http://svn.apache.org/viewcvs?rev=280049&view=rev
Log:
Eliminated unnecessary assignment statement in BisectionSolver.solve
method.
PR# 36491 (findbugs)
Also eliminated irrelevant test cases in ComplexTest introduced in r280031

Modified:
    jakarta/commons/proper/math/branches/MATH_1_1/src/java/org/apache/commons/math/analysis/BisectionSolver.java
    jakarta/commons/proper/math/branches/MATH_1_1/src/test/org/apache/commons/math/complex/ComplexTest.java

Modified: jakarta/commons/proper/math/branches/MATH_1_1/src/java/org/apache/commons/math/analysis/BisectionSolver.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/math/branches/MATH_1_1/src/java/org/apache/commons/math/analysis/BisectionSolver.java?rev=280049&r1=280048&r2=280049&view=diff
==============================================================================
--- jakarta/commons/proper/math/branches/MATH_1_1/src/java/org/apache/commons/math/analysis/BisectionSolver.java
(original)
+++ jakarta/commons/proper/math/branches/MATH_1_1/src/java/org/apache/commons/math/analysis/BisectionSolver.java
Sat Sep 10 16:37:39 2005
@@ -87,7 +87,6 @@
             if (fm * fmin > 0.0) {
                 // max and m bracket the root.
                 min = m;
-                fmin = fm;
             } else {
                 // min and m bracket the root.
                 max = m;

Modified: jakarta/commons/proper/math/branches/MATH_1_1/src/test/org/apache/commons/math/complex/ComplexTest.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/math/branches/MATH_1_1/src/test/org/apache/commons/math/complex/ComplexTest.java?rev=280049&r1=280048&r2=280049&view=diff
==============================================================================
--- jakarta/commons/proper/math/branches/MATH_1_1/src/test/org/apache/commons/math/complex/ComplexTest.java
(original)
+++ jakarta/commons/proper/math/branches/MATH_1_1/src/test/org/apache/commons/math/complex/ComplexTest.java
Sat Sep 10 16:37:39 2005
@@ -169,9 +169,6 @@
         assertTrue(realNaN.equals(imaginaryNaN));
         assertTrue(imaginaryNaN.equals(complexNaN));
         assertTrue(realNaN.equals(complexNaN));
-        Double d = new Double(Double.NaN);
-        Double d2 = new Double(Double.NaN);
-        assertTrue(d.equals(d2));
     }
     
     public void testHashCode() {



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message