Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 11964 invoked from network); 7 Aug 2005 17:03:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 7 Aug 2005 17:03:24 -0000 Received: (qmail 29506 invoked by uid 500); 7 Aug 2005 17:03:22 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 28989 invoked by uid 500); 7 Aug 2005 17:03:20 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 28976 invoked by uid 99); 7 Aug 2005 17:03:20 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Aug 2005 10:03:20 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [194.25.134.17] (HELO mailout02.sul.t-online.com) (194.25.134.17) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Aug 2005 10:03:09 -0700 Received: from fwd26.aul.t-online.de by mailout02.sul.t-online.com with smtp id 1E1oYP-0004S3-03; Sun, 07 Aug 2005 19:03:17 +0200 Received: from [192.168.0.1] (XZrTowZZweb3rYJaqhVrOb23iHcYyh5lzFb4M2F3j8Q3lSIGPchK4j@[84.174.95.101]) by fwd26.sul.t-online.de with esmtp id 1E1oYN-26K55s0; Sun, 7 Aug 2005 19:03:15 +0200 Message-ID: <42F63F0A.3040907@t-online.de> Date: Sun, 07 Aug 2005 19:04:10 +0200 From: Oliver Heger User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jakarta Commons Developers List Subject: Re: svn commit: r227018 [1/2] - in /jakarta/commons/proper/configuration/trunk: ./ conf/ src/java/org/apache/commons/configuration/ src/java/org/apache/commons/configuration/plist/ src/test/org/apache/commons/configuration/plist/ xdocs/ References: <20050802144337.17610.qmail@minotaur.apache.org> <42F4D679.1070309@t-online.de> <42F63B75.1020306@lfjr.net> In-Reply-To: <42F63B75.1020306@lfjr.net> X-Enigmail-Version: 0.89.6.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ID: XZrTowZZweb3rYJaqhVrOb23iHcYyh5lzFb4M2F3j8Q3lSIGPchK4j X-TOI-MSGID: e07f194e-5976-4374-b1d0-4e46508fa9b4 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Emmanuel Bourg wrote: > Oliver Heger a écrit : > >> The test case TestPropertyListConfiguration.testSave() fails for me >> in line 195 for the value of the 'dictionary-array' property. I >> assume ListAssert.assertEquals() is not able to compare two >> PropertyListConfiguration objects in the passed in lists. >> >> Could you please check this? > > > Sorry the commit was incomplete, this test assumes the configuration > defines its equals() methods. I added an equals() method in > AbstractConfiguration delegating to > StrictConfigurationComparator.compare() but I'm not sure it's worth > committing this. What do you think ? I'll fix the test if we rule out > this suggestion. > > Emmanuel Bourg I am not too convinced about the value of an equals() method either. Comparing two Configuration objects does not seem to be such a common task. And if it is needed, the comparator class can be used directly. If there was an equals() method, how would you implement hashCode()? Oliver --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org