Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 10843 invoked from network); 7 Aug 2005 16:50:01 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 7 Aug 2005 16:50:01 -0000 Received: (qmail 23210 invoked by uid 500); 7 Aug 2005 16:49:59 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 23144 invoked by uid 500); 7 Aug 2005 16:49:59 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 23131 invoked by uid 99); 7 Aug 2005 16:49:59 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Aug 2005 09:49:59 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [194.158.96.107] (HELO relay-av.club-internet.fr) (194.158.96.107) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Aug 2005 09:49:48 -0700 Received: from [195.36.146.207] (c02v-195-36-146-207.n.club-internet.fr [195.36.146.207]) by relay-av.club-internet.fr (Postfix) with ESMTP id D989325625 for ; Sun, 7 Aug 2005 18:49:15 +0200 (CEST) Message-ID: <42F63B75.1020306@lfjr.net> Date: Sun, 07 Aug 2005 18:48:53 +0200 From: Emmanuel Bourg User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.7.7) Gecko/20050414 X-Accept-Language: fr, en-us MIME-Version: 1.0 To: Jakarta Commons Developers List Subject: Re: svn commit: r227018 [1/2] - in /jakarta/commons/proper/configuration/trunk: ./ conf/ src/java/org/apache/commons/configuration/ src/java/org/apache/commons/configuration/plist/ src/test/org/apache/commons/configuration/plist/ xdocs/ References: <20050802144337.17610.qmail@minotaur.apache.org> <42F4D679.1070309@t-online.de> In-Reply-To: <42F4D679.1070309@t-online.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Oliver Heger a écrit : > The test case TestPropertyListConfiguration.testSave() fails for me in > line 195 for the value of the 'dictionary-array' property. I assume > ListAssert.assertEquals() is not able to compare two > PropertyListConfiguration objects in the passed in lists. > > Could you please check this? Sorry the commit was incomplete, this test assumes the configuration defines its equals() methods. I added an equals() method in AbstractConfiguration delegating to StrictConfigurationComparator.compare() but I'm not sure it's worth committing this. What do you think ? I'll fix the test if we rule out this suggestion. Emmanuel Bourg --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org