commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory" <ggreg...@seagullsoftware.com>
Subject RE: svn commit: r234327 - /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrTokenizer.java
Date Sun, 21 Aug 2005 21:58:31 GMT
Fixed in SVN and added a unit test to match.

My bad for not checking that a unit test was in place before mod'ing.

Thanks Stephen for catching this.

Gary

> -----Original Message-----
> From: Stephen Colebourne [mailto:scolebourne@btopenworld.com]
> Sent: Sunday, August 21, 2005 12:51 PM
> To: Jakarta Commons Developers List
> Subject: Re: svn commit: r234327 -
>
/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text
/S
> trTokenizer.java
> 
> ggregory@apache.org wrote:
> > Unnecessary cast from char[] to char[].
> >              StrTokenizer cloned = (StrTokenizer) super.clone();
> >              if (cloned.chars != null) {
> > -                cloned.chars = (char[]) cloned.chars;
> > +                cloned.chars = cloned.chars;
> >              }
> >              cloned.reset();
> >              return cloned;
> 
> should be
> cloned.chars = (char[]) cloned.chars.clone();
> 
> Stephen
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message