commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Libbrecht <p...@activemath.org>
Subject Re: [jelly] 1.0-final problem wrt tag caching
Date Sat, 13 Aug 2005 22:30:50 GMT
Indeed... it is running by me as well but I am fully puzzled.
I had added, after your commit, in my version the following which I 
believed was innocent... it wasn't: In TagScript.java, replace
     Tag tag = (Tag) threadLocalTagCache.get(t);

with
     Tag tag = null;
     if(context.isCacheTags())
       tag = (Tag) threadLocalTagCache.get(t);
Indeed, otherwise, the tag is only cleared at the start of next run.
Well, precisely this change made everything fail by me.

I'll have to evaluate further for more tags-that-wish-caching but for 
now... fine!

paul

Le 13 août 05, à 18:25, peter royal a écrit :

> On Aug 10, 2005, at 6:14 PM, Paul Libbrecht wrote:
>> I'm annoyed... I don't obtain the same results as you do.
>> With the default cacheTags value as false, I obtain only your test 
>> failing.
>>
>> With the default cacheTags value as true, I obtain many failed tests.
>>
>> Did you not say that with your commit, all jelly-core tests were 
>> passing ?
>>
>> If not then we really need to push the NeedCaching and RefusesCaching 
>> interfaces. Right ?
>
> yes, with the change I made, all the tests in jelly-core were passing. 
> can you give an example or two of a test that's failing for you?
>
> -pete
>
> -- 
> peter royal
>


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message