commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephen Colebourne <scolebou...@btopenworld.com>
Subject Re: svn commit: r234385 - /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrTokenizer.java
Date Mon, 22 Aug 2005 18:43:34 GMT
ggregory@apache.org wrote:
> -            if (ignoreEmptyTokens) {
> +            if (this.isIgnoreEmptyTokens()) {
>                  return;
>              }
> -            if (emptyAsNull) {
> +            if (this.isEmptyTokenAsNull()) {
>                  tok = null;
>              }

While I understand most of the change here, with the use of methods 
rather than direct field access, I dislike the above.

The 'this.' just seriously gets in the way of reading the code and adds 
nothing of value. Perhaps it is just an artifact of a tool you used?

Stephen

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message