commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephen Colebourne <scolebou...@btopenworld.com>
Subject Re: svn commit: r234327 - /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrTokenizer.java
Date Sun, 21 Aug 2005 19:50:57 GMT
ggregory@apache.org wrote:
> Unnecessary cast from char[] to char[].
>              StrTokenizer cloned = (StrTokenizer) super.clone();
>              if (cloned.chars != null) {
> -                cloned.chars = (char[]) cloned.chars;
> +                cloned.chars = cloned.chars;
>              }
>              cloned.reset();
>              return cloned;

should be
cloned.chars = (char[]) cloned.chars.clone();

Stephen

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message