commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oliver Heger <oliver.he...@t-online.de>
Subject Re: svn commit: r227018 [1/2] - in /jakarta/commons/proper/configuration/trunk: ./ conf/ src/java/org/apache/commons/configuration/ src/java/org/apache/commons/configuration/plist/ src/test/org/apache/commons/configuration/plist/ xdocs/
Date Sun, 07 Aug 2005 17:04:10 GMT
Emmanuel Bourg wrote:

> Oliver Heger a écrit :
>
>> The test case TestPropertyListConfiguration.testSave() fails for me 
>> in line 195 for the value of the 'dictionary-array' property. I 
>> assume ListAssert.assertEquals() is not able to compare two 
>> PropertyListConfiguration objects in the passed in lists.
>>
>> Could you please check this?
>
>
> Sorry the commit was incomplete, this test assumes the configuration 
> defines its equals() methods. I added an equals() method in 
> AbstractConfiguration delegating to 
> StrictConfigurationComparator.compare() but I'm not sure it's worth 
> committing this. What do you think ? I'll fix the test if we rule out 
> this suggestion.
>
> Emmanuel Bourg

I am not too convinced about the value of an equals() method either. 
Comparing two Configuration objects does not seem to be such a common 
task. And if it is needed, the comparator class can be used directly. If 
there was an equals() method, how would you implement hashCode()?

Oliver

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message