commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 36397] - [configuration][PATCH] conditional directives in property files
Date Sun, 28 Aug 2005 16:39:04 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=36397>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36397


oliver.heger@t-online.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|PATCH: conditional          |[configuration][PATCH]
                   |directives in property files|conditional directives in
                   |(commons-configuration)     |property files




------- Additional Comments From oliver.heger@t-online.de  2005-08-28 18:39 -------
Hey, this is interesting stuff! I think, it can be a good addition for
PropertiesConfiguration (and if somebody comes up with an idea how to make this
generic, for other configuration implementations as well).

Some remarks about your code:

- Did you test what happens if the directives appear in wrong order, e.g. an
%else without a corresponding %if? Maybe it would make sense to throw a
ConfigurationException then.

- It would be a good idea to define constants for the names of the directives,
in case they should be changed or a different start token (instead of %) should
be used.

- I assume there will be a problem with your implementation if a reloading
strategy is set for the Configuration object. This is because you invoke some
accessor methods, which trigger the reloading (an ugly side effect of the tight
coupling between a configuration and its reloading strategy). To work around
this issue you can call the enterNoReload() and exitNoReload() methods defined
in AbstractFileConfiguration.

In any case: Many thanks for your work!

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message