commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ra...@apache.org
Subject svn commit: r240375 - in /jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env: ELContext.java RootContext.java
Date Sat, 27 Aug 2005 02:07:42 GMT
Author: rahul
Date: Fri Aug 26 19:07:39 2005
New Revision: 240375

URL: http://svn.apache.org/viewcvs?rev=240375&view=rev
Log:
Found by FindBugs:

MS: org.apache.commons.scxml.env.ELContext.log isn't final but should be

True, since the intent is to share one Log for ELContext and its derivatives in the scxml.env
package.

Modified:
    jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/ELContext.java
    jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/RootContext.java

Modified: jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/ELContext.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/ELContext.java?rev=240375&r1=240374&r2=240375&view=diff
==============================================================================
--- jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/ELContext.java
(original)
+++ jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/ELContext.java
Fri Aug 26 19:07:39 2005
@@ -35,7 +35,7 @@
 public class ELContext implements Context , VariableResolver {
 
     /** Implementation independent log category. */
-    protected static Log log = LogFactory.getLog(Context.class);
+    protected static final Log LOG = LogFactory.getLog(Context.class);
     /** The parent Context to this Context. */
     protected Context parent = null;
     /** The Map of variables and their values in this Context. */
@@ -150,8 +150,8 @@
      */
     public void setLocal(final String name, final Object value) {
         vars.put(name, value);
-        if (log.isDebugEnabled() && !name.equals("_ALL_STATES")) {
-            log.debug(name + " = " + String.valueOf(value));
+        if (LOG.isDebugEnabled() && !name.equals("_ALL_STATES")) {
+            LOG.debug(name + " = " + String.valueOf(value));
         }
     }
 

Modified: jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/RootContext.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/RootContext.java?rev=240375&r1=240374&r2=240375&view=diff
==============================================================================
--- jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/RootContext.java
(original)
+++ jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/RootContext.java
Fri Aug 26 19:07:39 2005
@@ -40,7 +40,7 @@
     public RootContext(final JspContext ctx) {
         super();
         if (ctx == null) {
-            log.error("Host JSP Context cannot be null");
+            LOG.error("Host JSP Context cannot be null");
         }
         // only retain the VariableResolver
         this.vr = ctx.getVariableResolver();
@@ -59,7 +59,7 @@
             try {
                 value = vr.resolveVariable(name);
             } catch (ELException ele) {
-                log.error(ele.getMessage(), ele);
+                LOG.error(ele.getMessage(), ele);
             }
         }
         return value;
@@ -79,7 +79,7 @@
             try {
                 value = vr.resolveVariable(name);
             } catch (ELException ele) {
-                log.error(ele.getMessage(), ele);
+                LOG.error(ele.getMessage(), ele);
             }
             if (value != null) {
                 exists = true;



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message