commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tcu...@apache.org
Subject svn commit: r232871 - /jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/compilers/eclipse/EclipseJavaCompiler.java
Date Mon, 15 Aug 2005 20:44:10 GMT
Author: tcurdt
Date: Mon Aug 15 13:44:06 2005
New Revision: 232871

URL: http://svn.apache.org/viewcvs?rev=232871&view=rev
Log:
close the streams (thanks to Joerg)

Modified:
    jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/compilers/eclipse/EclipseJavaCompiler.java

Modified: jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/compilers/eclipse/EclipseJavaCompiler.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/compilers/eclipse/EclipseJavaCompiler.java?rev=232871&r1=232870&r2=232871&view=diff
==============================================================================
--- jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/compilers/eclipse/EclipseJavaCompiler.java
(original)
+++ jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/compilers/eclipse/EclipseJavaCompiler.java
Mon Aug 15 13:44:06 2005
@@ -16,6 +16,7 @@
 package org.apache.commons.jci.compilers.eclipse;
 
 import java.io.ByteArrayOutputStream;
+import java.io.IOException;
 import java.io.InputStream;
 import java.util.HashSet;
 import java.util.Locale;
@@ -170,8 +171,8 @@
                     try {
                         ClassFileReader classFileReader = new ClassFileReader(clazzBytes,
fileName, true);
                         return new NameEnvironmentAnswer(classFileReader, null);
-                    } catch (ClassFormatException e) {
-                        e.printStackTrace();
+                    } catch (final ClassFormatException e) {
+                        log.error("wrong class format", e);
                     }                    
 
                 }
@@ -190,7 +191,7 @@
                             
     	                        //log.debug("loading from classloader " + clazzName);
                             final byte[] buffer = new byte[8192];
-                            ByteArrayOutputStream baos = new ByteArrayOutputStream(buffer.length);
+                            final ByteArrayOutputStream baos = new ByteArrayOutputStream(buffer.length);
                             int count;
                             try {
                                 while ((count = is.read(buffer, 0, buffer.length)) > 0)
{
@@ -201,8 +202,24 @@
                                 final char[] fileName = clazzName.toCharArray();
                                 ClassFileReader classFileReader = new ClassFileReader(clazzBytes,
fileName, true);
                                 return new NameEnvironmentAnswer(classFileReader, null);
-                            } catch (Exception e) {
-                                e.printStackTrace();
+                            } catch (final IOException e) {
+                                log.error("could not read class", e);
+                            } catch (final ClassFormatException e) {
+                                log.error("wrong class format", e);
+                            } finally {
+                                try {
+                                    baos.close();
+                                } catch (IOException oe) {
+                                    log.error("could not close output stream", oe);
+                                }
+                                
+                                if (is != null) {
+                                    try {
+                                        is.close();
+                                    } catch (final IOException ie) {
+                                        log.error("could not close input stream", ie);
+                                    }
+                                }
                             }
 
     	                }



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message