commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 34942] - [VFS] no vfs_cache cleanup after ant task completed
Date Thu, 11 Aug 2005 04:39:13 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34942>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34942





------- Additional Comments From hoju@visi.com  2005-08-11 06:38 -------
Works great!

One issue with the downloads page.  It says commons-httpclient-2.0 and later. 
Except that commons-vfs won't compile with commons-httpclient-3.0....

WebdavConnectionManager fails to compile because it extends
HttpConnectionManager from commons-httpclient, but doesn't implement the
abstract method "getParams()" which, apparently, is a new method added to
HttpConnectionManager in 3.0 (RC2 is what I'm looking at right now). 
WebdavConnectionManager should either implement that method for the sake of
forward compatibility or the note should be changed to "commons-httpclient-2.x.x
only".  However, I would think that compatibility with 3.0 would be desired
moving forward.  After all, someone might want to use 3.0 along with VFS in a
project and run into jar hell.

Also, you build against commons-net-1.4.0 according to project.xml.  However,
you state in downloads that 1.2.1 is the minimum.  If you are willing to go
against 1.4.0, then you could get rid of deprecation warnings by using the
non-deprecated API which uses an FTPClientConfig object in
FTPClientWrapper.java.  I have a patch if you want it.

Anyway, the point is, it seems to me that you should keep the dependency
versions defined in download.xml in sync with those in project.xml.  Otherwise
you might end up fooling yourself and users by breaking backward compatibility
with asserted library versions without realizing it.  Thoughts?  

Now, one more thing.  I'd like to add Ant-1.6+ antlib functionality.  We'd keep
the tasks.properties file around for those that reference it, but we'd also add
an "antlib.xml".  This allows for all the functionality that is provided by
Antlib...
http://ant.apache.org/manual/CoreTypes/antlib.html

It simply looks like this (this file would be called "antlib.xml")...

<antlib>
    <taskdef resource="org/apache/commons/vfs/tasks/tasks.properties"/>
</antlib>

This would be added to the same "tasks" package where tasks.properties and all
the VFS Ant tasks exist.  Would you mind adding this?  It certainly won't hurt
anyone and it will help me and others wanting to use the antlib constructs.

Thanks!


Jake


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message