commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robert burrell donkin <robertburrelldon...@blueyonder.co.uk>
Subject Re: [PATCH] Betwixt - BeanWriter initial indent
Date Thu, 04 Aug 2005 20:25:46 GMT
hi alex

thnnks for the contribution.

i'm sad to say that unfortunately your attachment didn't make it through
to me. could you please attach it to a bugzilla report?

http://issues.apache.org/bugzilla

TIA

- robert

On Thu, 2005-08-04 at 18:44 +0800, Alex Ieong wrote:
> I've made a patch for this. 
> 
> And I've made the initial indent to ZERO by default, which made some
> test case fails because of this. But I think most people like this
> default and it won't cause problem in real world.
> 
> Please check. Thanks.
> 
> On 8/3/05, robert burrell donkin <robertburrelldonkin@blueyonder.co.uk> wrote:
> > On Wed, 2005-08-03 at 02:06 +0800, Alex Ieong wrote:
> > > Hello everybody,
> > >
> > > In org.apache.commons.betwixt.io.BeanWriter, I am wondering why the
> > > indentLevel starts at 1 with the first element. It makes the root
> > > element has indent too, which is ugly.
> > >
> > > Am I wrong or it has some purpose?
> > 
> > if it had some purpose, it is lost in the depths of time...
> > 
> > why not contribute a patch to apache that allows this value to be
> > configured?
> > 
> > - robert
> > 
> > 
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> > 
> > 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message