Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Received-SPF: pass (asf.osuosl.org: local policy)
content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [lang] Clover coverage of text.VariableFormatter
Date: Wed, 27 Jul 2005 09:58:56 +0200
Message-ID: <F0D7281DAB048B438E8F5EC4ECEFBDDC4E7713@esmail.elsag.de>
Thread-Topic: [lang] Clover coverage of text.VariableFormatter
Thread-Index: AcWSczF3o8p6ldLLQyyW68vk7Wa4GQADaNtg
From: =?iso-8859-1?Q?J=F6rg_Schaible?= <Joerg.Schaible@Elsag-Solutions.com>
To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>

Oliver Heger wrote on Wednesday, July 27, 2005 8:19 AM:

> J=F6rg Schaible wrote:
>> Gary Gregory wrote on Monday, July 25, 2005 9:13 PM:
>>=20
>>=20
>>> Oliver (or others):
>>>=20
>>> There is just one line of code marked with a "?" by Clover in
>>> VariableFormatter. The rest of the class is covered by the unit
>>> tests:=20
>>>=20
>>> http://people.apache.org/~ggregory/commons-lang/2.2-dev/docs/clover/
>>>=20
>>> I am not sure if this would be fixed by using the latest version of
>>> Clover but it means that we do not have 100% for VariableFormatter
>>> and it sure would be nice to get there.
>>>=20
>>> Can you shine a light on this or see if you can get that last line
>>> to get covered?
>>=20
>>=20
>> This means, that there is within this line more than one execution
>> path e.g. typically for ?: expessions or complex logical expressions.
>> Clover is aware, that you did not test all the paths and neither mark
>> the line as totally tested nor as untested.
>>=20
>> - J=F6rg
>>=20
>=20
> In our special case this would mean that not all conditions of the
> while-loop are triggered, right? These conditions test for
> the existence
> of a variable start token and of an end token after that.
> Looking at the
> unit tests I think that all possible combinations of existing and
> missing start and end tokens would be covered.
>=20
> Is it possible that because of the short cut evaluation of boolean
> expressions some pathes are never executed? Just a guess.

Definately! For a test just format the source so that each of the =
logical expressions is on its own line. Then is the logic of Clover =
obvious ...

- J=F6rg

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org