commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 35723] - [betwixt] [PATCH] add support for non-public setters
Date Thu, 14 Jul 2005 22:12:38 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=35723>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35723





------- Additional Comments From bugzilla.e.wuuza@xoxy.net  2005-07-15 00:12 -------
>Docs: I added a brief note to the documentation but if you'd like to check out

I added a couple of notes, including a note about SecurityManager issues.

>Updater: dot betwixt files should support both adders and setters through the

I added testing of private adders to the test case.  It correctly finds and uses
the adder, but calls it with a null value.  This is the same problem as the
"badItems" collection, which is why I presume that test case was previously
disabled.  I don't know why that part doesn't work correctly, since I have lots
of objects with adders that work fine.  It's not related to what I added, since
the badItems adder isn't private and it didn't work before.  So I would say the
accessibility stuff is verified, but something else is off.


>Java bean setters: the updater attribute is a plain method name and fails to
>look at java bean property setters. If you feel like creating a patch that
>checks properties (if no matching method is discovered) then I'll review it.

No, I wasn't suggesting that.  I just meant that even if the (private) setter
for "foo" is correctly named "setFoo" according to convention, you have to use 
  <element name='foo' updater='setFoo' forceAccessibility='true'/>
to override accessibility, not just
  <element name='foo' forceAccessibility='true'/>
It won't bother with the accessibility stuff unless updater is non-null.  I
don't think it is necessary to do the work to allow updater='foo' or anything
like that.



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message