commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 35621] - [configuration] Included properties w/ relative path fails in v1.1
Date Sun, 10 Jul 2005 18:30:38 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=35621>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35621





------- Additional Comments From oliver.heger@t-online.de  2005-07-10 20:30 -------
I committed a fix that should resolve the original problem. The main idea is
that AbstractFileConfiguration in its load(URL) method now always sets a base
path if none has been set before. The base path is simply set to the current
source URL. This works for relative include paths because ConfigurationUtils is
able to resolve a relative path in the context of a base URL.

About my last comment: I think I was a bit on the wrong track. The original
authors of PropertiesConfiguration did not support a way of disabling the
includes feature. setIncludesAllowed() is protected, and the flag's value is
only determined by the file to be loaded. I removed the initialization of the
includesAllowed flag (it was set to true), so now isIncludesAllowed() will
return the flag's value at the time the load() method was executed.

Mark, can you check if now everything works for you?

The question remains whether the includesAllowed flag makes sense any longer. My
fix causes the base path to be always valid when load() was successful. So the
flag will then always be true.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message