Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 35363 invoked from network); 30 Jun 2005 18:02:17 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 30 Jun 2005 18:02:17 -0000 Received: (qmail 49403 invoked by uid 500); 30 Jun 2005 18:02:13 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 49283 invoked by uid 500); 30 Jun 2005 18:02:12 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 49270 invoked by uid 99); 30 Jun 2005 18:02:12 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Jun 2005 11:02:12 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of mario@ops.co.at designates 194.152.182.4 as permitted sender) Received: from [194.152.182.4] (HELO smtp.ops.co.at) (194.152.182.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Jun 2005 11:02:14 -0700 Received: by smtp.ops.co.at (Postfix, from userid 65534) id C03EA23C0B0; Thu, 30 Jun 2005 20:02:09 +0200 (CEST) Received: from [192.168.3.1] (mgate.int.ops.co.at [172.27.0.11]) by smtp.ops.co.at (Postfix) with ESMTP id 6CA8923C0AC for ; Thu, 30 Jun 2005 20:02:06 +0200 (CEST) Message-ID: <42C433AF.6040101@ops.co.at> Date: Thu, 30 Jun 2005 20:02:23 +0200 From: Mario Ivankovits User-Agent: Mozilla Thunderbird 1.0 (X11/20041207) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jakarta Commons Developers List Subject: Re: [ANNOUNCE][VFS] commons-vfs 1.0 RC1 available References: <42C2FC16.4050800@ops.co.at> <1120124794.3783.103.camel@localhost.localdomain> In-Reply-To: <1120124794.3783.103.camel@localhost.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on smtp.ops.co.at X-Spam-Level: X-Virus-Checked: Checked by ClamAV on apache.org X-Old-Spam-Status: No, hits=-7.8 required=7.0 tests=AWL,BAYES_00,RATWR10_MESSID autolearn=no version=2.64 X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Hi Simon! Thanks for taking the time to check this all!! >Perhaps you could post your public GPG/PGP key so the signatures could >be checked too? > Did you mean the KEYS file within the distribution? Or any other place? >=== src.tar.gz > >The NOTICE.txt file is missing from the src distribution. > >A RELEASE-NOTES.txt file should also be included. Ok, will look at it. >The unit test classes are shipped with the source distribution (as >usual), but running "maven" reports: > >test:compile: > [echo] No test source files to compile. > >test:test: > [echo] No tests to run. > > All test are excluded as they need a complicated setup of some services. bin-distribution: >* no NOTICE.txt or RELEASE-NOTES.txt as for src >* no NOTICE.txt in jar's META-INF Is it optional to have it in META-INF or in the root? > ... Documentation ... All documentation problems fixed for next release (RC2) as suggested. >Public interface o.a.c.vfs.FileName generally omits the scope >declarations (ok, as all declarations are implicitly public in an >interface). However there is one method "getRoot" explicitly declared >public, which is a little inconsistent. Ok, will change it. I prefer to explicit declare modifiers. >=== final comments > >commons-vfs looks like a very impressive piece of work! Congratulations >to all the developers! > Thanks! Ciao, Mario --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org