Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Received-SPF: pass (asf.osuosl.org: domain of mfncooper@gmail.com designates
 64.233.184.193 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=tLcWS3K+bRgiEoJk3LWyIiJ7+44SNNEA22Q+Eeh7GO5PVpUibvrWfU4TUfvb/y4rKYEhjvaviXLLpqTdOdS5vkWwbF41W3W5gYxUWSoNcpv0sk0lWovCnvJG+3FuSJ+rdqvzk+RavQr14lvzsbaM/sox+8IVJpggZ6cCzvail4I=
Message-ID: <16d6c62005062010192efcb773@mail.gmail.com>
Date: Mon, 20 Jun 2005 10:19:15 -0700
From: Martin Cooper <mfncooper@gmail.com>
Reply-To: Martin Cooper <mfncooper@gmail.com>
To: Jakarta Commons Developers List <commons-dev@jakarta.apache.org>,
	jopaki <jopaki@gmail.com>
Subject: Re: Possible bug? [validator]
In-Reply-To: <8f7abac5050620090016e066cf@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <8f7abac5050620090016e066cf@mail.gmail.com>

I don't believe this is a bug. The 'results' variable holds the
results for the current field, and a new set of results is created for
each field. The overall results are maintained in the 'allResults'
field, and the contents of 'results' is merged into that near the end
of the loop.

--
Martin Cooper


On 6/20/05, jopaki <jopaki@gmail.com> wrote:
> Hi all,
>=20
> I downloaded commons-validator v1.1.4 and I think I ran into a bug in
> the method:
>=20
>     ValidatorResults validate(Map params, Map actions)
>         throws ValidatorException
>=20
> specifically the block:
> ********************************
>=20
>         for (int fieldNumber =3D 0; fieldNumber <
> numberOfFieldsToValidate; fieldNumber++) {
>=20
>             ValidatorResults results =3D new ValidatorResults();
>             // this is the "fix the bug" location
>=20
>             Iterator dependencies =3D this.dependencyList.iterator();
>             while (dependencies.hasNext()) {
>                 String depend =3D (String) dependencies.next();
>=20
>                 ValidatorAction action =3D (ValidatorAction) actions.get(=
depend);
>                 if (action =3D=3D null) {
>                     this.handleMissingAction(depend);
>                 }
>=20
>                 //ValidatorResults results =3D new ValidatorResults();
>                 // this is the "original" location that is "buggy"
>=20
>                 boolean good =3D
>                     validateForRule(action, results, actions, params,
> fieldNumber);
>=20
>                 allResults.merge(results);
>=20
>                 if (!good) {
>                     return allResults;
>                 }
>             }
>         }
> ********************************
>=20
> I moved the line that instantiates the local var: 'results'
> (ValidatorResults ) OUTSIDE of the while loop so the validations
> performed based on the dependencies (resolved to actions) are not lost
> between passes of the while loop.
>=20
> Please advise.
>=20
> Thanks!
>=20
> Jon Kirton
> jopaki@yahoo.com
> --
> -jpk-
>=20
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>=20
>

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org