commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephen Colebourne <scolebou...@btopenworld.com>
Subject Re: svn commit: r201882 - in /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang: enum/ enums/ exception/ math/
Date Sun, 26 Jun 2005 17:51:27 GMT
stevencaswell@apache.org wrote:
> Log:
> corrected style issues (mostly empty blocks and missing javadocs)
>           * <p>Restrictive constructor.</p>
>           */
>          private Entry() {
> +          ; // empty constructor
>          }
>      }

I would suggest the following as a more logical way to handle this

           private Entry() {
  +            super();
           }

Personally, I believe that constructors should always have a this() or 
super(), and in fact that is the checkstyle rule I would prefer to see ;-)

Stephen

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message