commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simon Kitching <skitch...@apache.org>
Subject Re: DO NOT REPLY [Bug 34661] - [logging][PATCH] Improvements to LogFactoryImpl
Date Wed, 15 Jun 2005 06:48:36 GMT
On Tue, 2005-06-14 at 23:31 -0700, Brian Stansberry wrote:
> > Re the InvocationTargetException for LogKitLogger:
> > 
> > Does it actually matter whether
> > ExceptionInInitializerError or
> > InvocationTargetException occurs for LogKitLogger?
[snip]
> Depends on how we resolve the issue of whether to ever
> fall into discovery if a relevant ALLOW...PROPERTY was
> set.  In the case of InvocationTargetException,
> ALLOW_FLAWED_DISCOVERY_PROPERTY would come into play.

True. 

As I said in the bugzilla note, I'm tempted to leave things as they are
(no attempt to recover from problems when user specifies a particular
library themselves). But I'm open to persuasion...

> Even if we decide _not_ to ever fall into discovery,
> its mildly tempting to patch LogKitLogger so it fails
> with the ExceptionInInitializerError.  Just so if some
> poor guys three years from now change something, the
> bug won't suddenly pop out.

That's fine by me. If you provide a patch I'll happily commit it.


Regards,

Simon


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message