commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simon Kitching <skitch...@apache.org>
Subject Re: DO NOT REPLY [Bug 34661] - [logging][PATCH] Improvements to LogFactoryImpl
Date Thu, 02 Jun 2005 06:39:27 GMT
On Wed, 2005-06-01 at 23:12 -0700, Brian Stansberry wrote:
> <snip>
> from:
> http://issues.apache.org/bugzilla/show_bug.cgi?id=34661
> 
> > ------- Additional Comments From
> > skitching@apache.org  2005-05-31 07:49 -------
> > I still don't understand that bit with the else
> > around the log4j discovery.
> > 
> > If someone has specified an explicit logclass, ie
> >   if (specifiedLogClassName != null)
> > is true then surely:
> >  * we create an instance of the specified class and
> > return it, or
> >  * we fail with an exception
> > 
> > I don't think we should *ever* fall back to
> > discovery mode if
> > specifiedLogClassName is not null. 
> 
> I agree with this philosophy but wanted to point out
> that if a user both:
> 
> 1) configures a Log class using a property, and
> 2) uses a property to configure JLC NOT to fail on an
> error
> 
> throwing an exception will contravene #2.
> 
> I don't have a problem with this, it just means the
> explanation of the usage of the "FailOnException"
> configuration property gets a bit more complicated.

We could call this property "FailOnDiscoveryException" instead.

By the way, I'm intending to make a few tweaks to the existing
LogFactoryImpl code in the next few hours. So please don't forget to svn
update before starting your work on this patch!

Regards,

Simon




---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message