Return-Path: 
 <commons-dev-return-72116-apmail-jakarta-commons-dev-archive=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org
Received: (qmail 65032 invoked from network); 1 Jun 2005 06:25:20 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 1 Jun 2005 06:25:20 -0000
Received: (qmail 75550 invoked by uid 500); 1 Jun 2005 06:25:16 -0000
Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org
Received: (qmail 75472 invoked by uid 500); 1 Jun 2005 06:25:16 -0000
Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:commons-dev-unsubscribe@jakarta.apache.org>
List-Help: <mailto:commons-dev-help@jakarta.apache.org>
List-Post: <mailto:commons-dev@jakarta.apache.org>
List-Id: "Jakarta Commons Developers List" <commons-dev.jakarta.apache.org>
Reply-To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Delivered-To: mailing list commons-dev@jakarta.apache.org
Received: (qmail 75459 invoked by uid 99); 1 Jun 2005 06:25:16 -0000
X-ASF-Spam-Status: No, hits=0.2 required=10.0
	tests=NO_REAL_NAME
X-Spam-Check-By: apache.org
Received: from ajax-1.apache.org (HELO ajax.apache.org) (192.87.106.226)
  by apache.org (qpsmtpd/0.28) with ESMTP; Tue, 31 May 2005 23:25:15 -0700
Received: by ajax.apache.org (Postfix, from userid 99)
	id 8EFDF184; Wed,  1 Jun 2005 08:25:02 +0200 (CEST)
From: bugzilla@apache.org
To: commons-dev@jakarta.apache.org
Subject: DO NOT REPLY [Bug 34613]  -
    [digester] Need to process [attribute id="name"]somename[/attribute]
X-Bugzilla-Reason: AssignedTo
Message-Id: <20050601062502.8EFDF184@ajax.apache.org>
Date: Wed,  1 Jun 2005 08:25:02 +0200 (CEST)
X-Virus-Checked: Checked
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34613>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34613





------- Additional Comments From markchristopherng@yahoo.com  2005-06-01 08:25 -------
Created an attachment (id=15239)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=15239&action=view)
adds simple attribute matching

I changed the following classes in the commons-digestor 1.6 so it can match
based on the attribute value

Modified  
RuleBase.add()
Digestor.startElement()

Added
Rule.attributeXpath 
Rule.getAttributeXpath()
Rule.setAttributeXpath()
Digestor.filterRulesByValidAttributeMatch()
Digestor.useAttributeRule()
Digestor.rebuildNode()

For the following exmple.

<people>
	<person>
		<location type="home">
			<postcode>3190<postcode>		
		</id>
	</person>
</people>

<digester-rules>
	<pattern value="people/person">
		<object-create-rule classname="com.Person" />
		<pattern value="location[@type='home']">	
			<call-method-rule pattern="postcode"
methodname="setPostcode" paramcount="0"/>
		</pattern>		
		<set-next-rule methodname="add" paramtype="java.lang.Object" />

	</pattern>
</digester-rules>


The person.postcode value will be 3190 as the xpath e.g.
people/person/location[@type='home'] /postcode matches the rules.

If the sample input was as follows then the person.postcode value would not be
set.


<people>
	<person>
		<location type="work">
			<postcode>3190<postcode>		
		</id>
	</person>
</people>


The modification to code is limited to defining one [@XXX] per xpath. Also i do
not pop all the of the attributes off the stack, only the ones i need. Is there
a better way to do this? 

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org