commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 34661] - [logging][PATCH] Improvements to LogFactoryImpl
Date Tue, 31 May 2005 15:43:33 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34661>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34661





------- Additional Comments From b_stansberry@hotmail.com  2005-05-31 17:43 -------
(In reply to comment #18)
> (In reply to comment #17)
> 
> PS: and this code would remain the same whatever future changes are made to
> createLogClass or handleFlawedDiscovery...
> 

You're right.  I was resisting the approach of returning after the call to 
createLogClass() because I generally don't like a bunch of return statements in 
a method.  But I realize now I was thinking in terms of returning after _every_ 
call to createLogClass(), which would add a bunch of returns.  This is not 
necessary and not what you're suggesting; adding a return for the one special 
case of specifiedLogClassName makes sense and clarifies the code.

Thanks.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message