commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 34661] - [logging][PATCH] Improvements to LogFactoryImpl
Date Mon, 30 May 2005 04:11:28 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34661>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34661


b_stansberry@hotmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14880|0                           |1
        is obsolete|                            |




------- Additional Comments From b_stansberry@hotmail.com  2005-05-30 06:11 -------
Created an attachment (id=15207)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=15207&action=view)
diff to LogFactoryImpl rev 3

Attached is a considerably cleaned up and revised version of the previous
patches.  Major changes are:

1) Incorporates the internal diagnostics Simon Kitching recently added to SVN
trunk.
2) Adds configuration property "org.apache.commons.logging.FailOnException",
configurable either as a system property or in a commons-logging.properties
file.  If set to true, JCL will fail with a LogConfigurationException if a Log
adapter and its associated logging library are discovered but an instance
cannot be created.  This situation is referred to as a "flawed discovery".  If
the property is false or unset, flawed discoveries will be logged using
whatever log adapter is eventually discovered.
3) Lots and lots of comments.
4) General tightening up of the code, fixing of subtle issues, etc.
5) Protected methods that are no longer invoked by the class are marked as
deprecated (wouldn't mind chopping them out -- this class now exceeds 1000
lines).

Using this class all the unit tests invoked by the build.xml test target pass. 
There is a problem with the LoadTest unit test found in the src/test tree; I've
posted on commons-dev about this.

Using this class all 32 cases listed in Robert's demonstration document work as
expected.  To see examples of how the logging of "flawed discovery" works, run
cases 20, 24 and 28.

Need to test what happens if I turn on the "FailOnException" switch, but
thought it would be good to let others have a look.

Will follow with an attachment of the complete source file in case its easier
to read.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message