Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 54764 invoked from network); 19 Apr 2005 18:39:19 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 19 Apr 2005 18:39:19 -0000 Received: (qmail 79402 invoked by uid 500); 19 Apr 2005 18:39:15 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 79338 invoked by uid 500); 19 Apr 2005 18:39:15 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 79325 invoked by uid 500); 19 Apr 2005 18:39:15 -0000 Received: (qmail 79322 invoked by uid 99); 19 Apr 2005 18:39:15 -0000 X-ASF-Spam-Status: No, hits=-9.8 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from minotaur.apache.org (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.28) with SMTP; Tue, 19 Apr 2005 11:39:13 -0700 Received: (qmail 54754 invoked by uid 65534); 19 Apr 2005 18:39:12 -0000 Message-ID: <20050419183912.54753.qmail@minotaur.apache.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: svnmailer-1.0.0-dev Date: Tue, 19 Apr 2005 18:39:12 -0000 Subject: svn commit: r161946 - in jakarta/commons/sandbox/i18n/trunk: project.xml src/java/org/apache/commons/i18n/ResourceBundleMessageProvider.java src/java/org/apache/commons/i18n/XMLMessageProvider.java To: commons-cvs@jakarta.apache.org From: jmitchell@apache.org X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: jmitchell Date: Tue Apr 19 11:39:11 2005 New Revision: 161946 URL: http://svn.apache.org/viewcvs?view=3Drev&rev=3D161946 Log: add 2 new reports, remove needless object creation Modified: jakarta/commons/sandbox/i18n/trunk/project.xml jakarta/commons/sandbox/i18n/trunk/src/java/org/apache/commons/i18n/Res= ourceBundleMessageProvider.java jakarta/commons/sandbox/i18n/trunk/src/java/org/apache/commons/i18n/XML= MessageProvider.java Modified: jakarta/commons/sandbox/i18n/trunk/project.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/sandbox/i18n/trunk/proje= ct.xml?view=3Ddiff&r1=3D161945&r2=3D161946 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D --- jakarta/commons/sandbox/i18n/trunk/project.xml (original) +++ jakarta/commons/sandbox/i18n/trunk/project.xml Tue Apr 19 11:39:11 2005 @@ -114,5 +114,19 @@ maven-jxr-plugin maven-license-plugin maven-tasklist-plugin + maven-jcoverage-plugin + =20 + + maven-findbugs-plugin + =20 Modified: jakarta/commons/sandbox/i18n/trunk/src/java/org/apache/commons/i1= 8n/ResourceBundleMessageProvider.java URL: http://svn.apache.org/viewcvs/jakarta/commons/sandbox/i18n/trunk/src/j= ava/org/apache/commons/i18n/ResourceBundleMessageProvider.java?view=3Ddiff&= r1=3D161945&r2=3D161946 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D --- jakarta/commons/sandbox/i18n/trunk/src/java/org/apache/commons/i18n/Res= ourceBundleMessageProvider.java (original) +++ jakarta/commons/sandbox/i18n/trunk/src/java/org/apache/commons/i18n/Res= ourceBundleMessageProvider.java Tue Apr 19 11:39:11 2005 @@ -46,7 +46,6 @@ * @see org.apache.commons.i18n.MessageProvider#getText(java.lang.Stri= ng, java.lang.String, java.util.Locale) */ public String getText(String id, String entry, Locale locale) throws M= essageNotFoundException { - String text =3D null; for ( Iterator i =3D installedResourceBundles.iterator(); i.hasNex= t(); ) { String baseName =3D (String)i.next(); try { Modified: jakarta/commons/sandbox/i18n/trunk/src/java/org/apache/commons/i1= 8n/XMLMessageProvider.java URL: http://svn.apache.org/viewcvs/jakarta/commons/sandbox/i18n/trunk/src/j= ava/org/apache/commons/i18n/XMLMessageProvider.java?view=3Ddiff&r1=3D161945= &r2=3D161946 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D --- jakarta/commons/sandbox/i18n/trunk/src/java/org/apache/commons/i18n/XML= MessageProvider.java (original) +++ jakarta/commons/sandbox/i18n/trunk/src/java/org/apache/commons/i18n/XML= MessageProvider.java Tue Apr 19 11:39:11 2005 @@ -138,7 +138,6 @@ } =20 static class ConfigurationHandler extends DefaultHandler { - private Map messages =3D new HashMap(); private String id, key; private Message message; private StringBuffer cData; --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org