commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steve Cohen <sco...@javactivity.org>
Subject Re: [net] [ftp] [patch] FTPTimestampParserImplTest.java and FTPClientConfigTest.java
Date Sat, 02 Apr 2005 03:45:07 GMT
Yes it does, thank you very much.
Neeme Praks wrote:
> 
> No, they don't pass on a machine that has a default locale set to 
> something non-english.
> 
> The problem is that the tests are assuming too much about the default 
> locale.
> For example, if you create a new SimpleDateFormat without providing a 
> locale or a set of DateFormatSymbols then that SimpleDateFormat will use 
> the default stuff. And then the test code assumes that it will get 
> english month names but, for example in my case, it will get Estonian 
> month names and it will fail.
> 
> I hope that clarified things up a bit?
> 
> Rgds,
> Neeme
> 
> Steve Cohen wrote:
> 
>> What do you mean, "make the tests pass"?  The tests, as written, 
>> already pass.  Perhaps you are saying that the tests don't test 
>> everything they need to test.  But you have not identified what those 
>> issues are.
>>
>> If you come up with a test case that shows a problem, then the 
>> solution is to add the test and fix the code as necessary.
>>
>> Or am I misunderstanding you?
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message