commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 34661] - [logging][PATCH] Improvements to LogFactoryImpl
Date Fri, 29 Apr 2005 06:14:01 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34661>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34661





------- Additional Comments From b_stansberry@hotmail.com  2005-04-29 08:14 -------
Created an attachment (id=14880)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=14880&action=view)
diff to LogFactoryImpl

OK, had a chance to clean up some; attached is a diff.	The code could still
stand to simmer on the stove a while; I particularly want to check through the
exception handling.

Thanks for pointing out the protected methods; they've been uncommented.  I
changed their implementation to be more consistent with the way the new
discovery works.  This means they will behave differently than the current
implementation.  I could have left the old code (in which case they would be
completely backwards compatible).  Not sure what the right approach is.

For now I've left all the new methods I wrote private; some could certainly be
protected if we decide we want to expose them.

I'll attach a new copy of the class (non-diff) in a moment.

If I get a chance I'll try to come up with something to doc the code flow, but
might be a while.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message