commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 34437] New: - commons logging 1.0.4 does not use log4j 1.3 trace methods
Date Wed, 13 Apr 2005 13:12:24 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34437>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34437

           Summary: commons logging 1.0.4 does not use log4j 1.3 trace
                    methods
           Product: Commons
           Version: 1.0.4
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Logging
        AssignedTo: commons-dev@jakarta.apache.org
        ReportedBy: pdegregorio@comcast.net


Jakarta Commons Logging 1.0.4 detects log4j 1.3 and alters its behaviour 
accordingly but continues to map its trace methods to log4j debug methods 
while log4j 1.3 now has its own trace methods. The following patch fixes this 
bug: 

Index: commons-
logging/src/java/org/apache/commons/logging/impl/Log4JLogger.java
===================================================================
--- commons-logging/src/java/org/apache/commons/logging/impl/Log4JLogger.java
	(revision 161137)
+++ commons-logging/src/java/org/apache/commons/logging/impl/Log4JLogger.java
	(working copy)
@@ -84,7 +84,7 @@
         if(is12) {
             getLogger().log(FQCN, (Priority) Level.DEBUG, message, null );
         } else {
-            getLogger().log(FQCN, Level.DEBUG, message, null );
+            getLogger().log(FQCN, Level.TRACE, message, null );
         }
     }
 
@@ -97,7 +97,7 @@
         if(is12) {
             getLogger().log(FQCN, (Priority) Level.DEBUG, message, t );
         } else {
-            getLogger().log(FQCN, Level.DEBUG, message, t );
+            getLogger().log(FQCN, Level.TRACE, message, t );
         }
     }
 
@@ -277,7 +277,11 @@
      * For Log4J, this returns the value of <code>isDebugEnabled()</code>
      */
     public boolean isTraceEnabled() {
-        return getLogger().isDebugEnabled();
+        if(is12) {
+            return getLogger().isDebugEnabled();
+        } else {
+            return getLogger().isTraceEnabled();
+        }
     }
 
     /**

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message