commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 33980] - Get Method based on method description
Date Mon, 14 Mar 2005 04:29:41 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=33980>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33980





------- Additional Comments From skitching@apache.org  2005-03-14 05:29 -------
This looks reasonable to me. I'm not one of the regular BeanUtils maintainers,
though so I would prefer to see someone else second the motion before committing
the patch.

By the way, which class should these changes be applied to?

I would suggest using HashMap rather than Hashtable as the data structure;
Beanutils already requires 1.1 or later, and the synchronization that Hashtable
automatically provides should not be needed as the maps are read-only.

Unit tests are also needed for this code. Having unit tests is *very* important,
and new functionality really can't be added without them. If you aren't familiar
with how to write or execute unit tests for commons-beanutils I'm happy to offer
help with this.

And does the code handle both of these cases?
  public void foo(String[] param)
  public void foo(String param[])

And finally there are some minor issues like javadoc and reasonable messages in
thrown exceptions. I'm sure these were just left out until it was decided
whether the patch would be accepted; hopefully some other beanutils maintainer
will agree it should be.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message