commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 18942] - [beanutils] Add "t/f" to BooleanConverter
Date Fri, 04 Mar 2005 15:49:02 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=18942>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=18942





------- Additional Comments From jakarta@rizzoweb.com  2005-03-04 16:49 -------
(In reply to comment #14)
> (In reply to comment #10)
> > [Simon]
> > > 
> > >      knownStrings = new Hashtable();
> > >      knownStrings.put("true", Boolean.TRUE);
> > >      ....
> > > 
> > [Eric response]
> > Any particular reason why you prefer that way?
> 
> Currently, getKnownStrings calls addTrueString, which calls back into
> getKnownStrings, which returns a reference to a partially-initialised map which
> is then updated before control returns to getKnownStrings. I think this does
> work as expected, but it seems a rather complex flow of calls.


It really is a minor thing. I tend to have classes "eat their own dogfood" -
IOW, utilize internally the public interface that they publish (why? because if
a change is made to the logic in addTrueString() then the lazy initializer will
already be using it). A lot of people don't do that. No big deal. It does not
cause any harm here, but it appears there are bigger battles to fight with this
and I'll choosek my battles carefully ;-)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message