Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Received-SPF: pass (hermes.apache.org: domain of oliver.zeigermann@gmail.com
 designates 64.233.184.195 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:references;
        b=FDrKBO/ogq2mUOtO7O18SCLKsD44ZW/u0/LDQU0AiaydSSYac+XIZ51oYU/0hhZ5bbFwTw+spEDWqO94AZcdUDJB1Aw9FW/gnCD+8T8gzoPyMxU3e08u6QKAo4ZtErzAOWRWiEzQNPjIB9nPl9Xv0VAgWdUnRrO+ilcUQiyjqAY=
Message-ID: <9da4f45205020109046dc93980@mail.gmail.com>
Date: Tue, 1 Feb 2005 18:04:52 +0100
From: Oliver Zeigermann <oliver.zeigermann@gmail.com>
Reply-To: ozeigermann@apache.org
To: Jakarta Commons Developers List <commons-dev@jakarta.apache.org>,
	skitching@apache.org
Subject: Re: [digester] initial code for Digester2.0
In-Reply-To: <1107166168.4607.22.camel@blackbox>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
References: <1107166168.4607.22.camel@blackbox>

I very much like that and think it really is straight forward.

Comments:
- Why is Action an abstract class?
- Wouldn't it be possible (and even desirable) to have a more general
Pattern class instead of a String in Digester#addRule?
- I like the bodySegment vs. body design :)
- I like the no dependency and digester2 package approach
- It's no secret that I am no fun of reflection stuff: is it really
necessary to have the subclasses of Action be part of the *very*,
*very* digester *core*?

If so I would be more than happy to abandon xmlio (in) as - apart from
philosophical considerations - it would be superfluous and I would
offer development support for digester if that is welcome.

Oliver

On Mon, 31 Jan 2005 23:09:28 +1300, Simon Kitching <skitching@apache.org> wrote:
> Hi,
> 
> As I mentioned a few months ago, I've been working on some ideas for
> Digester 2.0. I've put some code and notes up on
>   http://www.apache.org/~skitching
> 
> Comments from all commons-dev subscribers are welcome, but particularly
> from Craig and Robert.
> 
> The RELEASE-NOTES.txt file gives a brief overview of what I've done so
> far, and what I personally would like to see.
> 
> This is *not* intended to be final code, but rather to solicit yes/no
> feedback on what people like/dislike about the posted code. As you will
> see, many parts are still missing and I personally would still like to
> see significant changes even to parts already included (see
> RELEASE-NOTES.txt). However the basic structure is there, including a
> number of controversial (I expect) name changes.
> 
> Once we get the general opinions out, and I have massaged the code into
> something that meets general concensus I hope to then add it to the
> sandbox for everyone to hack away at.
> 
> Cheers,
> 
> Simon
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> 
>

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org