commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oliver Zeigermann <oliver.zeigerm...@gmail.com>
Subject Re: [digester] initial code for Digester2.0
Date Tue, 01 Feb 2005 17:04:52 GMT
I very much like that and think it really is straight forward.

Comments:
- Why is Action an abstract class?
- Wouldn't it be possible (and even desirable) to have a more general
Pattern class instead of a String in Digester#addRule?
- I like the bodySegment vs. body design :)
- I like the no dependency and digester2 package approach
- It's no secret that I am no fun of reflection stuff: is it really
necessary to have the subclasses of Action be part of the *very*,
*very* digester *core*?

If so I would be more than happy to abandon xmlio (in) as - apart from
philosophical considerations - it would be superfluous and I would
offer development support for digester if that is welcome.

Oliver

On Mon, 31 Jan 2005 23:09:28 +1300, Simon Kitching <skitching@apache.org> wrote:
> Hi,
> 
> As I mentioned a few months ago, I've been working on some ideas for
> Digester 2.0. I've put some code and notes up on
>   http://www.apache.org/~skitching
> 
> Comments from all commons-dev subscribers are welcome, but particularly
> from Craig and Robert.
> 
> The RELEASE-NOTES.txt file gives a brief overview of what I've done so
> far, and what I personally would like to see.
> 
> This is *not* intended to be final code, but rather to solicit yes/no
> feedback on what people like/dislike about the posted code. As you will
> see, many parts are still missing and I personally would still like to
> see significant changes even to parts already included (see
> RELEASE-NOTES.txt). However the basic structure is there, including a
> number of controversial (I expect) name changes.
> 
> Once we get the general opinions out, and I have massaged the code into
> something that meets general concensus I hope to then add it to the
> sandbox for everyone to hack away at.
> 
> Cheers,
> 
> Simon
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> 
>

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message