commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 33331] - [betwixt] Custom Object<->String Conversion in .betwixt file
Date Sun, 13 Feb 2005 22:05:45 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=33331>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33331





------- Additional Comments From rdonkin@apache.org  2005-02-13 23:05 -------
Hi Matt

Thanks for the patch.

I've taken a quick look at your code. I think I get the general idea but think
that I would prefer an alternative implementation strategy. (Betwixt is a
complex beast and it's important to keep an eye on code clarity.) 

I can't see any unit tests for this functionality or a documentation patch
describing this extra feature. Documentation and tests are very important. I
find that it frequently takes me as long to create tests and documentation as it
does to create the implementation. If you could supply tests and documentation
for the feature, it'd reduce the amount of time it'd take me to add this feature
which would in turn increase the chance that I'd find time to add it soon. 

Robert

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message